Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use binderhub as the build backend #72

Closed
jtpio opened this issue Feb 22, 2024 · 2 comments · Fixed by #83
Closed

Use binderhub as the build backend #72

jtpio opened this issue Feb 22, 2024 · 2 comments · Fixed by #83

Comments

@jtpio
Copy link
Member

jtpio commented Feb 22, 2024

Follow-up to a chat with @yuvipanda.

Currently tljh-repo2docker relies on repo2docker directly for building the environments. For example:

config = {
"Cmd": cmd,
"Image": "quay.io/jupyterhub/repo2docker:main",
"Labels": {
"repo2docker.repo": repo,
"repo2docker.ref": ref,
"repo2docker.build": image_name,
"tljh_repo2docker.display_name": name,
"tljh_repo2docker.mem_limit": memory,
"tljh_repo2docker.cpu_limit": cpu,
},
"Volumes": {
"/var/run/docker.sock": {
"bind": "/var/run/docker.sock",
"mode": "rw",
}
},
"HostConfig": {
"Binds": ["/var/run/docker.sock:/var/run/docker.sock"],
},
"Tty": False,
"AttachStdout": False,
"AttachStderr": False,
"OpenStdin": False,
}
if username and password:
config.update(
{
"Env": [f"GIT_CREDENTIAL_ENV=username={username}\npassword={password}"],
}
)
async with Docker() as docker:
await docker.containers.run(config=config)

But for use cases like the ones described 2i2c-org/binderhub-service#78, or to be able to reuse the new UI for building environments (developed in #69) more easily in other JupyterHub deployments, it could make sense to start relying on binderhub for building the images.

@jtpio
Copy link
Member Author

jtpio commented Mar 28, 2024

@jtpio jtpio linked a pull request Apr 10, 2024 that will close this issue
@jtpio jtpio mentioned this issue Apr 17, 2024
@jtpio
Copy link
Member Author

jtpio commented May 15, 2024

As noticed in #83 (review), it looks like we might not be able to use BinderHub to build private git repos: jupyterhub/binderhub#1834

@jtpio jtpio closed this as completed in #83 May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant