Add react-based frontend #69
Conversation
|
Thanks @trungleduc for working on this! Do you have a screenshot around for what the new frontend / UI looks like, even if it's still a draft for now and subject to changes? Thanks! |
|
@jtpio I updated the first post. |
trungleduc
force-pushed
the
new-fewd
branch
25 times, most recently
from
ddeedca
to
34ebeb6
Compare
trungleduc
force-pushed
the
new-fewd
branch
6 times, most recently
from
7e0fcc0
to
7c201cc
Compare
|
@jtpio this PR is ready again |
.yarnrc.yml
Outdated
| @@ -0,0 +1,2 @@ | |||
| nodeLinker: node-modules | |||
There was a problem hiding this comment.
If this simplifies the setup, we could also use npm instead of yarn?
There was a problem hiding this comment.
indeed, updated!
Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
.github/workflows/build.yml
Outdated
| uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 | ||
|
|
||
| - name: Lint the application | ||
| shell: bash -l {0} |
There was a problem hiding this comment.
Maybe this shell (and the others below) could be removed if we use the base-setup action?
There was a problem hiding this comment.
Thanks @trungleduc!
It's also really nice to have UI tests and reference snapshots 👍
Maybe we could even replace the screenshots in the README by the snapshots from the UI test, so the README stays up-to-date when new changes land?
|
I didn't go through the whole frontend code in the details, but overall it looked good. We can always iterate on it later if something needs to be fixed. |
I will do it in the follow-up PR |
Code changes
Screenshot