Replace the service by extra hub handlers #19
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more of a cleanup change to simplify the code base.
The idea is to add extra handlers directly to JupyterHub, instead of running the environment service in a separate process.
Instead the handlers run in the same process as the hub. Which means that it simplifies the access to some hub components such as static files and other settings. Also the navbar stays consistent across pages.
Changes
aiodocker
to talk to Docker withasyncio
(to remove the need to executors)