-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for GIT_CREDENTIAL_ENV to build private repos #42
Conversation
Hiding the credential inputs in a optional-credentials.mp4 |
cc @adriendelsalle this makes it possible to provide credentials to be able to clone private repositories. It looks like providing a |
when this is going to be merged? |
@srggrs probably soon. If you would like to test, you can install the plugin from this branch with the following passed to the TLJH installer: --plugin git+https://github.com/jtpio/tljh-repo2docker@private-repos |
cc @pierrepo in case you have some inputs w.r.t the UI, since it adds two new fields to the dialog (collapsed by default) |
Hey @jtpio sorry for the delay. |
Thanks for checking it out 👍 |
Fixes #27
This makes it possible to pass a
username
andpassword
from the UI:private-repo.mp4
Using
repo2docker
support forGIT_CREDENTIAL_ENV
(some info in jupyterhub/repo2docker@504aeb7)For example with GitHub, a user can generate a new access token with the
read
scope:And use this token as the password.
Similar with GitLab: