Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional name to the environment #7

Merged
merged 6 commits into from
Apr 30, 2020
Merged

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Apr 30, 2020

Fixes #6

image

name-tooltip-2

@jtpio jtpio marked this pull request as ready for review April 30, 2020 13:19
@jtpio
Copy link
Member Author

jtpio commented Apr 30, 2020

The regular expression might look a bit like random characters to the user at first glance, but at least it corresponds to the real regex used to validate the string.

@pierrepo
Copy link
Contributor

pierrepo commented Apr 30, 2020

Very nice @jtpio
Could you add a placeholder for the Name field? For instance course-Python-101-B37 or something equivalent?
Is is possible to have a hint message to give more info on input fields? For instance for the Name field a hint message could be "Name of the environment. Allowed characters are A to Z, a to z, 0 to 9, - and _"

@jtpio
Copy link
Member Author

jtpio commented Apr 30, 2020

Could you a placeholder for the Name field? For instance course-Python-101-B37 or something equivalent?

That can be useful indeed. Although the placeholder is not going to be the default value if left empty (while it is for the Reference).

Is is possible to have a hint message to give more info on input fields? For instance for the Name field a hint message could be "Name of the environment. Allowed characters are A to Z, a to z, 0 to 9, - and _"

I agree that the list of characters next to "Name" looks a bit odd actually. We can probably hide this in a tooltip.

@jtpio
Copy link
Member Author

jtpio commented Apr 30, 2020

We can probably hide this in a tooltip.

Or maybe just a message above / below the input field.

@jtpio
Copy link
Member Author

jtpio commented Apr 30, 2020

With a tooltip:

name-tooltip

@pierrepo
Copy link
Contributor

That can be useful indeed. Although the placeholder is not going to be the default value if left empty (while it is for the Reference).

Oh yes. So it is probably NOT a good idea.

Or maybe just a message above / below the input field.

Yes. Below sound great.
So we could add, below the Name input field something like "For instance, course-Python-101-B37 or 2020-MEG-M1-UE42"

Or tooltip could do the job too ;-)

@jtpio
Copy link
Member Author

jtpio commented Apr 30, 2020

Something like this could be nice:

name-tooltip-2

@pierrepo
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let user define image name
2 participants