Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add releaser workflow #74

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Add releaser workflow #74

merged 4 commits into from
Mar 11, 2024

Conversation

trungleduc
Copy link
Collaborator

@trungleduc trungleduc commented Mar 6, 2024

Closes #71

@trungleduc trungleduc force-pushed the releaser branch 2 times, most recently from fd42905 to 191a262 Compare March 6, 2024 09:57
id: prep-release
uses: jupyter-server/jupyter_releaser/.github/actions/prep-release@v2
with:
token: ${{ secrets.ADMIN_GITHUB_TOKEN }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we don't have a bot for the plasmabio org, wondering if we should try to use a GitHub app instead, as suggested by this change in the releaser repo: jupyter-server/jupyter_releaser#557

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, could you create an app for the plasmabio org?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me check, but not sure I have admin rights on the org.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I don't have access to the organization settings at the moment.

cc @pierrepo who might be able to help with this. For context we are trying to setup automated releases for tljh-repo2docker using the Jupyter Releaser.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jtpio is here anything I could do for you?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's possible to give use rights to manage apps here: https://github.com/organizations/plasmabio/settings/apps. I dont' have access to that URL but normally it should be the right one.

Not sure if that will be enough for us to create a GitHub app for the organization, or if we would also need to become owners of the org. Normally it should be enough according to the docs:

https://docs.github.com/en/apps/creating-github-apps/registering-a-github-app/registering-a-github-app#about-registering-github-apps

You can register a GitHub App under your personal account, under an organization that you own, or under an organization that has granted you permission to manage all apps owned by the organization

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be ok @jtpio :

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@jtpio
Copy link
Member

jtpio commented Mar 6, 2024

Just published a placeholder package to PyPI: https://pypi.org/project/tljh-repo2docker/

Add setup the trusted publisher:

image

@trungleduc
Copy link
Collaborator Author

Great!

@jtpio
Copy link
Member

jtpio commented Mar 8, 2024

Following https://jupyter-releaser.readthedocs.io/en/latest/how_to_guides/convert_repo_from_repo.html.

We now have the GitHub App created:

image

And the two secrets defined in this repo for the release environment:

image

I haven't added a ruleset yet for now to keep things simple, but we can consider adding it later.

@trungleduc
Copy link
Collaborator Author

@jtpio is it ready to go?

@jtpio
Copy link
Member

jtpio commented Mar 11, 2024

I think so.

Let's merge and try to make a release?

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@trungleduc trungleduc merged commit 88838b7 into plasmabio:master Mar 11, 2024
7 checks passed
@trungleduc trungleduc deleted the releaser branch March 12, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt jupyter_releaser
3 participants