Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start single server from backend #81

Merged
merged 6 commits into from
Apr 3, 2024
Merged

Conversation

trungleduc
Copy link
Collaborator

@trungleduc trungleduc commented Apr 1, 2024

Reference

Due to the changes in JupyterHub 4.1.2, users can not send a POST request to the JupyterHub server from tljh-repo2docker's frontend anymore. This PR adds new endpoints to start and stop single-server from the service's backend

Code changes

  • New endpoints: /api/servers allowing users to start and stop a single server.
  • The frontend is updated appropriately to use the new endpoint.

@trungleduc trungleduc marked this pull request as ready for review April 3, 2024 09:53
@trungleduc trungleduc requested a review from jtpio April 3, 2024 10:42
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio
Copy link
Member

jtpio commented Apr 3, 2024

Wondering if we should recommend using JupyterHub 4.1.2 or higher, for example in the README?

@trungleduc
Copy link
Collaborator Author

The service should work with any version of JupyterHub, so JupyterHub >=4 is enough

@jtpio
Copy link
Member

jtpio commented Apr 3, 2024

ok 👍

@jtpio jtpio merged commit 094e463 into plasmabio:master Apr 3, 2024
7 checks passed
@trungleduc trungleduc added the enhancement New feature or request label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants