Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0.x] StreamedResponse headers map is now case insensitive #909

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

mkurz
Copy link
Member

@mkurz mkurz commented Jul 8, 2024

@mkurz mkurz marked this pull request as draft July 8, 2024 12:19
@mkurz mkurz changed the title [3.0.x] Add tests for StreamedResponse to make sure its header's map is case … [3.0.x] StreamedResponse headers map is now case insensitively Jul 8, 2024
@mkurz
Copy link
Member Author

mkurz commented Jul 8, 2024

In Scala 3 we can't override class parameter's "getter"s anymore:

[error] -- [E120] Naming Error: /home/runner/work/play-ws/play-ws/play-ahc-ws-standalone/src/main/scala/play/api/libs/ws/ahc/StreamedResponse.scala:56:15 
[error] 56 |  override def headers(): Map[String, scala.collection.Seq[String]] = {
[error]    |               ^
[error]    |Double definition:
[error]    |private[this] val headers: Map[String, scala.collection.Seq[String]] in class StreamedResponse at line 45 and
[error]    |override def headers(): Map[String, scala.collection.Seq[String]] in class StreamedResponse at line 56
[error] one error found

@mkurz
Copy link
Member Author

mkurz commented Jul 8, 2024

@Mergifyio backport main

Copy link
Contributor

mergify bot commented Jul 8, 2024

backport main

✅ Backports have been created

@mkurz
Copy link
Member Author

mkurz commented Jul 8, 2024

@Mergifyio backport 2.2.x

Copy link
Contributor

mergify bot commented Jul 8, 2024

backport 2.2.x

✅ Backports have been created

@mkurz mkurz force-pushed the case-insensitively-headers-maps branch from 86e07f5 to 329a4bc Compare July 8, 2024 13:00
@mkurz mkurz marked this pull request as ready for review July 8, 2024 13:37
@mkurz mkurz merged commit fe2bda4 into playframework:3.0.x Jul 8, 2024
14 checks passed
@mkurz mkurz deleted the case-insensitively-headers-maps branch July 8, 2024 13:37
@mkurz mkurz changed the title [3.0.x] StreamedResponse headers map is now case insensitively [3.0.x] StreamedResponse headers map is now case insensitive Jul 8, 2024
mkurz added a commit that referenced this pull request Jul 8, 2024
[2.2.x] [3.0.x] StreamedResponse `headers` map is now case insensitive (backport #909) by @mkurz
mkurz added a commit that referenced this pull request Jul 8, 2024
[main] StreamedResponse `headers` map is now case insensitive (backport #909) by @mkurz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant