Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Scrolling with errors #211

Merged
merged 4 commits into from
Nov 30, 2022
Merged

fix: Scrolling with errors #211

merged 4 commits into from
Nov 30, 2022

Conversation

whizzzkid
Copy link
Collaborator

Addresses: #207 (comment)

In this PR:

  • Making the entire container scroll to reveal roadmap.
  • Fixing roadmap after height is reached.
  • Bonus: Added issue count.

@vercel
Copy link

vercel bot commented Nov 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
starmaps ✅ Ready (Inspect) Visit Preview Nov 30, 2022 at 6:49AM (UTC)

@whizzzkid whizzzkid changed the base branch from main to fix/scrollable-height November 30, 2022 06:49
@SgtPooki
Copy link
Contributor

SgtPooki commented Nov 30, 2022 •
edited
Loading

I've got some repro steps for you, but console.error causes nextjs to throw a big annoying banner up :| so you might need to just do this locally:

  1. visit http://localhost:3000/roadmap/github.com/ipfs/ipfs-gui/issues/106#detail (full, new, page load)
  2. click the group header "Theme: Kubo feature parity" (i.e. Theme: Kubo feature parity ipfs/ipfs-gui#121)
  3. click the browser back button

This has consistently resulted in the following screenshot for me on your branch
image

edit: moved this to #215

SgtPooki
SgtPooki approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@SgtPooki SgtPooki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even with my other comments about the errors, this is a fantastic improvement. much much cleaner!

note: mobile view (narrow width) causes the root issue title to wrap, which ends up causes some of the header to not be visible

image

components/errors/ErrorNotificationHeader.tsx
@@ -26,7 +27,7 @@ export function ErrorNotificationHeader({ isExpanded, toggle }: ErrorNotificatio
<Flex>
<Center>
<WarningTwoIcon color="#F39106" ml="1rem" mr="1rem" width={iconWandH} height={iconWandH} />
<Text fontSize="20">Issues with roadmap</Text>
<Text fontSize="20">{errorCount} issue{errorCount > 1 && 's'} with roadmap</Text>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. I had this in a branch somewhere and it got lost =)

@SgtPooki SgtPooki mentioned this pull request Nov 30, 2022
Closed
@SgtPooki SgtPooki merged commit 6a7668f into fix/scrollable-height Nov 30, 2022
@SgtPooki SgtPooki deleted the feature/fix/scrollable-height branch November 30, 2022 08:01
@whizzzkid whizzzkid mentioned this pull request Dec 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtPooki SgtPooki SgtPooki approved these changes

@juliaxbow juliaxbow Awaiting requested review from juliaxbow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whizzzkid @SgtPooki