maint(pat structure): fixing structure tests

jest.config.js

@@ -2,5 +2,8 @@ const path = require("path");
 const config = require("@patternslib/dev/jest.config.js");
 
 config.setupFilesAfterEnv.push(path.resolve(__dirname, "./src/setup-tests.js"));
+config.transformIgnorePatterns = [
+    "/node_modules/(?!@patternslib/)(?!@plone/)(?!preact/)(?!screenfull/)(?!bootstrap/)(?!datatable/)(?!regenerator-runtime/).+\\.[t|j]sx?$",
+];
 
 module.exports = config;

package.json

@@ -46,7 +46,7 @@
         "@11ty/eleventy": "^1.0.2",
         "@11ty/eleventy-navigation": "^0.3.5",
         "@11ty/eleventy-plugin-syntaxhighlight": "^4.2.0",
-        "@patternslib/dev": "^3.1.8",
+        "@patternslib/dev": "^3.1.9",
         "@types/sinon": "^10.0.13",
         "npm-run-all": "^4.1.5",
         "rimraf": "^3.0.2",

src/core/utils.js

@@ -367,7 +367,7 @@ var storage = {
     },
 };
 
-const ICON_CACHE = new Map();
+export const ICON_CACHE = new Map();
 
 /**
  * Return a <svg> element from a icon name.

src/pat/datatables/datatables.js

@@ -1,4 +1,3 @@
-import $ from "jquery";
 import "regenerator-runtime/runtime"; // needed for ``await`` support
 import Base from "@patternslib/patternslib/src/core/base";
 
@@ -39,6 +38,6 @@ export default Base.extend({
         await import("datatables.net-select");
         //await import("datatables.net-select-bs5");
 
-        $(this.el).DataTable(this.options);
+        this.$el.DataTable(this.options);
     },
 });

src/pat/structure/js/actions.js

@@ -1,4 +1,3 @@
-import $ from "jquery";
 import _t from "../../../core/i18n-wrapper";
 import utils from "../../../core/utils";
 import Backbone from "backbone";

src/pat/structure/js/collections/result.js

@@ -1,4 +1,3 @@
-import $ from "jquery";
 import Backbone from "backbone";
 import Result from "../models/result";
 import utils from "../../../../core/utils";
@@ -13,11 +12,10 @@ export default Backbone.PageableCollection.extend({
         this.view = options.view;
         this.url = options.url;
 
-        this.queryHelper = utils.QueryHelper(
-            $.extend(true, {}, this.view.options, {
-                attributes: this.view.options.queryHelperAttributes,
-            })
-        );
+        this.queryHelper = utils.QueryHelper({
+            attributes: this.view.options.queryHelperAttributes,
+            ...this.view.options
+        });
 
         this.queryParser = function (options) {
             if (options === undefined) {
@@ -29,11 +27,10 @@ export default Backbone.PageableCollection.extend({
 
             return JSON.stringify({
                 criteria: this.queryHelper.getCriterias(
-                    term,
-                    $.extend({}, options, {
+                    term, {
                         additionalCriterias: this.view.additionalCriterias,
-                    })
-                ),
+                        ...options,
+                    }),
                 sort_on: sortOn,
                 sort_order: sortOrder,
             });

src/pat/structure/js/views/table.js

@@ -50,9 +50,7 @@ export default BaseView.extend({
             "last_comment_date",
         ];
 
-        self.translatableColumns = [
-            "review_state",
-        ];
+        self.translatableColumns = ["review_state"];
     },
 
     events: {
@@ -63,7 +61,7 @@ export default BaseView.extend({
     setContextInfo: function () {
         const data = this.contextInfo;
         /* set breadcrumb title info */
-        const crumbs = data.breadcrumbs;
+        const crumbs = data && data.breadcrumbs;
         if (crumbs && crumbs.length) {
             const $crumbs = this.$(".fc-breadcrumbs a.crumb");
             _.each(crumbs, (crumb, idx) => {
@@ -77,7 +75,6 @@ export default BaseView.extend({
         // By default do not start sorted by any column
         // Ignore first column and the last one (activeColumns.length + 1)
         // Do not show paginator, search or information, we only want column sorting
-
         const datatables_options = {
             order: [0, "asc"],
             columnDefs: [