breaking(core utils): Remove createElementFromHTML. Use create_from_s…

…tring from Patternslib core dom instead.
plone · May 31, 2022 · 7033e97 · 7033e97
1 parent 0ecfb33
commit 7033e97
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 11 deletions.
diff --git a/src/core/utils.js b/src/core/utils.js
@@ -367,13 +367,6 @@ var storage = {
     },
 };
 
-var createElementFromHTML = function (htmlString) {
-    // From: https://stackoverflow.com/a/494348/1337474
-    var div = document.createElement("div");
-    div.innerHTML = htmlString.trim();
-    return div.firstChild;
-};
-
 const ICON_CACHE = new Map();
 
 /**
@@ -460,5 +453,4 @@ export default {
     resolveIcon: resolveIcon,
     setId: setId,
     storage: storage,
-    createElementFromHTML: createElementFromHTML,
 };
diff --git a/src/pat/structure/js/views/app.js b/src/pat/structure/js/views/app.js
@@ -1,6 +1,7 @@
 import $ from "jquery";
 import _ from "underscore";
 import _t from "../../../../core/i18n-wrapper";
+import dom from "@patternslib/patternslib/src/core/dom";
 import utils from "../../../../core/utils";
 import logging from "@patternslib/patternslib/src/core/logging";
 import Cookies from "js-cookie";
@@ -571,13 +572,13 @@ export default BaseView.extend({
             return;
         }
 
-        const el = utils.createElementFromHTML(
+        const el = dom.create_from_string(
             this.statusTemplate({
                 label: status.label || "",
                 text: status.text,
                 type: status.type || "warning",
             })
-        );
+        ).lastChild;
 
         if (btn) {
             btn = $(btn)[0]; // support jquert + bare dom elements
@@ -614,7 +615,7 @@ export default BaseView.extend({
             }
         }
         this.$el.append(
-            utils.createElementFromHTML('<div class="fc-status-container"></div>')
+            dom.create_from_string('<div class="fc-status-container"></div>')
         );
         if (this.columnsView) {
             this.$el