Merge pull request #1304 from plone/fix-external-images-having-pictur…

…evariants-61 fix: Do not add picture-variants classes and attributes to external i…
plone · Apr 12, 2023 · 8bff993 · 8bff993
2 parents f9917b1 + a6e6161
commit 8bff993
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/src/pat/tinymce/js/links.js b/src/pat/tinymce/js/links.js
@@ -664,8 +664,10 @@ export default Base.extend({
         var cssclasses = [
             "image-richtext",
             self.$align.val(),
-            "picture-variant-" + self.$scale.val(),
         ];
+        if(self.linkType !== "externalImage"){
+            cssclasses.push("picture-variant-" + self.$scale.val())
+        }
         if (captionFromDescription || caption) {
             cssclasses.push("captioned");
         }
@@ -681,11 +683,14 @@ export default Base.extend({
                 "alt": self.$alt.val(),
                 "class": cssclasses.join(" "),
                 "data-linkType": self.linkType,
-                "data-picturevariant": self.$scale.val(),
                 "data-scale": self.getScaleFromSrcset(self.$scale.val()),
             },
             self.linkTypes[self.linkType].attributes()
         );
+        if(self.linkType !== "externalImage"){
+            data["data-picturevariant"] = self.$scale.val();
+        }
+
         if (caption && !captionFromDescription) {
             data["data-captiontext"] = caption;
         }