Skip to content

Commit

Permalink
maint(Bundle): Move dependency backbone.paginator to devDependencies …
Browse files Browse the repository at this point in the history
…to avoid version conflicts.

backbone.paginator is now in devDependencies as it requests outdated
versions of Backbone and Underscore. Having this in normal dependencies
field would eventually let backbone.paginator register itself in an
outdated Backbone version and make it unavailable by those used in
structure pattern.
Having this in devDependencies avoids this, but also makes the structure
pattern unavailable in add-on bundles unless this dependency is
explicitly added.
However, this should be fixed in a more sane way. But that's out of
scope for now.
  • Loading branch information
thet committed May 23, 2022
1 parent 51e9077 commit f40f64d
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,13 @@
"description": "A collection of client side patterns for faster and easier web development",
"license": "BSD-3-Clause",
"main": "./src/patterns.js",
"dependenciesComments": {
"backbone.paginator": "Dependency moved to devDependencies since it requests oudated versions of Backbone and Underscore. Not fixing this dependencies in other bundles would make use paginator those outdated dependencies and result in a broken structure pattern."
},
"dependencies": {
"@patternslib/pat-code-editor": "^2.1.2",
"@patternslib/patternslib": "^8.0.2",
"backbone": "1.4.1",
"backbone.paginator": "1.0.0",
"bootstrap": "^5.2.0-beta1",
"bootstrap-icons": "^1.8.2",
"cs-jqtree-contextmenu": "0.1.0",
Expand Down Expand Up @@ -53,6 +55,7 @@
"@testing-library/jest-dom": "^5.16.4",
"@types/sinon": "^10.0.11",
"babel-loader": "^8.2.5",
"backbone.paginator": "1.0.0",
"copy-webpack-plugin": "^11.0.0",
"copyfiles": "^2.4.1",
"core-js": "3.22.5",
Expand Down

0 comments on commit f40f64d

Please sign in to comment.