Use dropdown styles from node_modules, instead of from stored css file #2277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
components/dash-core-components/src/fragments/Dropdown.react.js
Outdated
Show resolved
Hide resolved
alexcjohnson
approved these changes
Oct 27, 2022
There was a problem hiding this comment.
💃 Thanks @nickmelnikov82 - looks good! Just one small comment / question, then we need a changelog entry and this will be ready.
Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>
T4rk1n
force-pushed
the
update-dropdown-styles
branch
from
c2601af
to
787b974
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated styles for dcc.Dropdown to make styles actual. Close #2273 issue.
Contributor Checklist
optionals
CHANGELOG.md