copy histogram autobinx/y back to the input trace #1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on par with colors and axis ranges
alexcjohnson
commented
Jul 20, 2017
| var autoBinAttr = 'autobin' + maindata; | ||
| var binspec = trace[binAttr]; | ||
| if((trace[autoBinAttr] !== false) || !binspec || | ||
| binspec.start === null || binspec.end === null) { |
There was a problem hiding this comment.
note that cleanBins provides a size even if there are no start or end. This also doesn't allow you to specify a start and no end or things like that. So partial bin definition might do strange things... but that I would definitely consider a feature we could propose to add, rather than a bug to fix.
Also note that !(binAttr in trace) in the old version never failed, since we default to null for start and end (which might have been important to enable cleanBins?) - so in principle I could omit !binspec here, just thought it prudent in case there's some context I'm not aware of that can call this calc.
etpinard
reviewed
Jul 20, 2017
| expect(gd._fullData[0].autobiny).toBe(true); | ||
| }); | ||
|
|
||
| it('respects explicit autobin: false as a one-time autobin', function() { |
Nicely done and thanks for not forgetting about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on par with colors and axis ranges
fixes #24
@etpinard are you OK with this?