Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganization [part 2] #2

Merged
merged 39 commits into from
Nov 16, 2015
Merged

Reorganization [part 2] #2

merged 39 commits into from
Nov 16, 2015

Conversation

etpinard
Copy link
Contributor

@alexcjohnson @bpostlethwaite @cldougl

This PR mostly moves files around in src/

css/
fonts/
snapshot/

assets/
  - topojson/
  - geo_assets.js

lib/
  - coerce.js 
  - nested_property.js
  - ... (including the current gl and geo lib modules)

components/
  - annotations/
  - color/
  - colorscale/
  - colorbar/
  - drawing/
  - errorbars/
  - shapes/
  - legend/
  - modebar/
  - titles/ (contents of Plotly.Plots.title)

constants/
  - geo_constants.js (the current geo/lib/params.js)
  - country-name_to_iso3.json
  - gl2d_dashes.json
  - gl3d_dashes.json
  - gl_markers.json

plot_api/ (the method to expose to users)
  - plot_api.js
  - plot_schema.js
plots/ 
  - cartesian/
    - axes.js
    - graph_interact.js (rename?, break up hover label stuff into components/hover_labels.js)
  - geo/
    - geo.js
    - layout/
      - attributes.js 
      - defaults.js
    - projections.js
    - set_scale.js
    - zoom.js
    - zoom_reset.js
  - gl2d/
    - scene2d.js
    - gl2daxes.js (convert step between plotly --> gl-vis)
    - camera.js
  - gl3d/
    - scene3d.js
    - layout/
       - attributes.js
       - defaults.js
      - attributes/
      - defaults/
      - convert.js
      - spikes.js
      - tick_marks.js
    - project.js
    - camera.js
  - plots.js  (what is left of Plotly.Plots)

traces/
  - scatter/
    - attributes.js
    - defaults.js
    - calc.js
    - plot.js 
    - style.js
    - scatter.js
  - bars/
  - boxes/
  - contour/
  - heatmap/
  - histogram/
  - pie/
  - scatter3d/
    - attributes.js
    - defaults.js
    - convert.js
    - plot.js 
    - scatter3d.js
  - surface/
  - mesh/
  - scattergeo/
  - choropleth/
  - scattergl/

plot_config.js
plotly.js
index.js  # the file to be browserify file exposing only Plotly.plot and friends

- Plotly methods go in src/plot_api/plot_api.js
- Plotly.Plots module goes in src/plots/plots/plots.js
- break up attribute object in Plotly.Plots into seperate files
- factor Plotly.Plots.titles into components/titles/
- coerce.js, dates.js, matrix.js nested_property.js,
  notifier.js, search.js, stats.js
- do not require in Plotly when not necessary
- keep GeoLayout module (for now)
- merge GeoAxes into GeoLayout
- keep Gl3dLayout (for now)
- merge Gl3dAxes into Gl3dLayout
- browserify that file so that window.Plotly doesn't contain
  internal methods
-  folders in plots/ are reserved for plot types
- attributes.js ALWAYS refers to trace attributes
- layout_attributes.js ALWAYS referes to layout attributes
  - Queue is now part of plotly.js and always there
etpinard and others added 7 commits November 13, 2015 18:51
- to extend the default config with the API.
- rename src/$type/$module_name/$module_name.js ->
  src/$type/$module_name/index.js

  so that require('../$type/$module_name/$module_name') becomes
  require('../$type?$module_name')
mainly so sublime doesn't complain about node
@alexcjohnson
Copy link
Collaborator

Beautiful. 💃

- rm maxparms
- rm maxstatements
- bump maxdepth to 6
- add jasmine env
etpinard added a commit that referenced this pull request Nov 16, 2015
@etpinard etpinard merged commit c3c71e6 into master Nov 16, 2015
@etpinard etpinard deleted the reorg-src branch November 16, 2015 03:04
etpinard pushed a commit that referenced this pull request Aug 2, 2016
Horizontal legend in columns
etpinard pushed a commit that referenced this pull request Feb 8, 2017
@apalchys apalchys mentioned this pull request Aug 22, 2017
monfera added a commit that referenced this pull request Oct 5, 2017
jSharpWolf pushed a commit to jSharpWolf/plotly.js that referenced this pull request Mar 21, 2018
etpinard pushed a commit that referenced this pull request Oct 5, 2018
ayjayt pushed a commit to geopozo/plotly.js that referenced this pull request Jan 29, 2024
FIX and Add options to chart2music plotly integration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants