Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bound scalar marker size in legend item #2840

Merged
merged 3 commits into from
Aug 2, 2018

Conversation

etpinard
Copy link
Contributor

fixes #2833, but does affect a handful of our baselines.

@alexcjohnson what do you think? Were scaler marker.size values supposed to remain unbounded in legend items?

- setting d.ms isn't enough here, as downstread in Drawing.pointStyle
  subtypes.isBubble is used to determine if d.ms or trace.marker.size
  is used to draw the legend item.
@alexcjohnson
Copy link
Collaborator

Huh, I thought we already did that. Anyway yes, this is good. 💃

@etpinard
Copy link
Contributor Author

OK great, I think this should be part of 1.40.0, not 1.39.3 though.

@etpinard etpinard added this to the v1.40.0 milestone Jul 24, 2018
@etpinard etpinard merged commit 6f94816 into master Aug 2, 2018
@etpinard etpinard deleted the bound-scalar-markersize-in-legenditem branch August 2, 2018 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Categorical legend for bubble chart renders incorrectly when category has only 1 value
2 participants