Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scatter3d now performs axis transformation on error bars #2992

Merged
merged 5 commits into from
Sep 17, 2018

Conversation

antoinerg
Copy link
Contributor

Fixes #2962

Applies axis transformation on error bars in scatter3d to deal with log scale appropriately.

@antoinerg
Copy link
Contributor Author

I tried to reuse code from scattergl but it turns out it bails out of drawing error bars with negative lower bounds (see #3009)

@etpinard
Copy link
Contributor

Not the most ideal fix, but good enough considering the current state of 3D.

Reusing more things for cartesian is probably going to be difficult before we tackle #2646, which we may not tackle before the regl rewrite (#949), so let's get this fix in ASAP 💃

@antoinerg
Copy link
Contributor Author

Ok sounds good! I'll merge it now :)

@antoinerg antoinerg merged commit c422725 into master Sep 17, 2018
@antoinerg antoinerg deleted the 2962-scatter3d-log-error-bars branch September 17, 2018 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants