-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stacked area layering and deletion bugs #3005
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
37ee992
fix #3003 - fill and layering for multiple stackgroups and unstacked …
alexcjohnson f6c5d56
fix #3002 - allow deleting stack groups
alexcjohnson fe0c988
describe fill reordering in scatter attributes
alexcjohnson 72c61c7
clean cruft out of stacked_area_groups mock
alexcjohnson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
{ | ||
"data": [ | ||
{ | ||
"x": [0, 2, 4], "y": [6, 1, 6], "line": {"color": "#000"}, | ||
"name": "bottom", "legendgroup": "l" | ||
}, { | ||
"x0": -0.5, "y": [1, 2, 3, 4, 5], "name": "a 1", | ||
"stackgroup": "a", "legendgroup": "a", | ||
"line": {"color": "#f00"}, "fillcolor": "rgba(255,0,0,0.8)" | ||
}, { | ||
"x0": 0.5, "y": [5, 4, 3, 2, 1], "name": "b 1", | ||
"stackgroup": "b", "legendgroup": "b", | ||
"line": {"color": "#00f"}, "fillcolor": "rgba(0,0,255,0.8)" | ||
}, { | ||
"x0": -0.5, "y": [1, 1, 1, 1, 1], "name": "a 2", | ||
"stackgroup": "a", "legendgroup": "a", | ||
"line": {"color": "#f80"}, "fillcolor": "rgba(255,136,0,0.8)" | ||
}, { | ||
"x0": 1, "y": [1, 2, 1], "name": "unstacked 1", | ||
"fill": "tozeroy", "legendgroup": "u", | ||
"line": {"color": "#888"}, "fillcolor": "rgba(136,136,136,0.8)" | ||
}, { | ||
"x0": -0.5, "y": [1, 1, 1, 1, 1], "name": "a 3", | ||
"stackgroup": "a", "legendgroup": "a", | ||
"line": {"color": "#ff0"}, "fillcolor": "rgba(255,255,0,0.8)" | ||
}, { | ||
"x0": 0.5, "y": [1, 1, 1, 1, 1], "name": "b 2", | ||
"stackgroup": "b", "legendgroup": "b", | ||
"line": {"color": "#80f"}, "fillcolor": "rgba(136,0,255,0.8)" | ||
}, { | ||
"x0": 1, "y": [5, 8, 5], "name": "unstacked 2", | ||
"fill": "tonexty", "legendgroup": "u", | ||
"line": {"color": "#ccc"}, "fillcolor": "rgba(204,204,204,0.8)" | ||
}, { | ||
"x": [0, 2, 4], "y": [7, 3, 7], "line": {"color": "#0c0"}, | ||
"name": "top", "legendgroup": "l" | ||
}, { | ||
"x0": 0.5, "y": [1, 1, 1, 1, 1], "name": "b 3", | ||
"stackgroup": "b", "legendgroup": "b", | ||
"line": {"color": "#f0f"}, "fillcolor": "rgba(255,0,255,0.8)" | ||
} | ||
], | ||
"layout": { | ||
"width": 500, | ||
"height": 500, | ||
"title": "Stack groups and unstacked filled traces", | ||
"xaxis": {"title": "infer zero"}, | ||
"xaxis2": {"title": "interpolate"}, | ||
"grid": {"columns": 1, "rows": 2, "pattern": "independent"} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@etpinard it doesn't seem like animations can remove traces, is that correct? That's what it looks like, since I don't see a
join.exit()
associated with them (sinceisFullReplot = !transitionOpts
)... yet the comment above implies that you can add traces:So... do I need to worry about animations deleting traces or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, removing traces with
'frame.redraw': false
(i.e. without a replot at the end of the animation), doesn't work currently:https://codepen.io/etpinard/pen/ZMRReB
so I don't think you broke anything here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah Ricky wrote an issue about this #932