Fix modebar <style> update in IE11 #3187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- that override DOM methods to catch browser-dependent (i.e. IE) bugs
etpinard
commented
Oct 30, 2018
| 'use strict'; | ||
|
|
||
| (function(arr) { | ||
| arr.forEach(function(item) { |
There was a problem hiding this comment.
Taken from @alexcjohnson 's #3186 (comment), this gave
before the previous commit.
I chose to throw instead of logging to avoid situations like the one solved in #3168.
There was a problem hiding this comment.
Note: we could also add unpolyfill.js to our image tests (like we do for strict-d3).
I chose not to as throwing errors in our jasmine test should be enough to catch these bugs and debugging the old nw.js image server is a pain.
|
Beautiful! Thanks @etpinard for fixing my mistake so quickly! 💃 when the tests pass! I love the new test. This mistake won't be happening again 😄 ! |
|
Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fixup of #3068 for IE11, which hopefully will be enough to close #3186. It would be nice to add a test before merging this in.
cc @plotly/plotly_js