Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume3d iso #3479

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/traces/isosurface/attributes.js
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,8 @@ colorscaleAttrs('', {

colorbar: colorbarAttrs,

opacity: surfaceAtts.opacity,

// Flat shaded mode
flatshading: {
valType: 'boolean',
Expand Down
2 changes: 1 addition & 1 deletion src/traces/isosurface/convert.js
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ proto.update = function(data) {
fresnel: data.lighting.fresnel,
vertexNormalsEpsilon: data.lighting.vertexnormalsepsilon,
faceNormalsEpsilon: data.lighting.facenormalsepsilon,
opacity: 1, // Note: no need to create transparent surfaces
opacity: data.opacity,
contourEnable: data.contour.show,
contourColor: str2RgbaArray(data.contour.color).slice(0, 3),
contourWidth: data.contour.width,
Expand Down
1 change: 1 addition & 0 deletions src/traces/isosurface/defaults.js
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
'lightposition.y',
'lightposition.z',
'flatshading',
'opacity'
].forEach(function(x) { coerce(x); });

colorscaleDefaults(traceIn, traceOut, layout, coerce, {prefix: '', cLetter: 'c'});
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added test/image/baselines/gl3d_volume3d_data-cube.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2,663 changes: 2,663 additions & 0 deletions test/image/mocks/gl3d_volume3d_between-ranges.json

Large diffs are not rendered by default.

2,663 changes: 2,663 additions & 0 deletions test/image/mocks/gl3d_volume3d_data-cube.json

Large diffs are not rendered by default.