Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plot schema should not show line.shape options for scatterpolargl trace #6781

Merged
merged 2 commits into from
Nov 9, 2023
Merged

plot schema should not show line.shape options for scatterpolargl trace #6781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ce7ab2
scatterpolargl.line should not have shape option
archmoj Nov 9, 2023
3e86994
log for PR 6781
archmoj Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions draftlogs/6781_fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fix plot schema not to show `line.shape` options for `scatterpolargl` trace [[#6781](https://github.com/plotly/plotly.js/pull/6781)]
8 changes: 7 additions & 1 deletion src/traces/scatterpolargl/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,13 @@ module.exports = {
hovertext: scatterPolarAttrs.hovertext,
hovertemplate: scatterPolarAttrs.hovertemplate,

line: scatterGlAttrs.line,
line: {
color: scatterGlAttrs.line.color,
width: scatterGlAttrs.line.width,
dash: scatterGlAttrs.line.dash,
editType: 'calc'
},

connectgaps: scatterGlAttrs.connectgaps,

marker: scatterGlAttrs.marker,
Expand Down
13 changes: 0 additions & 13 deletions test/plot-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58874,19 +58874,6 @@
},
"editType": "calc",
"role": "object",
"shape": {
"description": "Determines the line shape. The values correspond to step-wise line shapes.",
"dflt": "linear",
"editType": "calc",
"valType": "enumerated",
"values": [
"linear",
"hv",
"vh",
"hvh",
"vhv"
]
},
"width": {
"description": "Sets the line width (in px).",
"dflt": 2,
Expand Down