Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump target from es5 to es2016 #7017

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ jobs:
command: npm run test-requirejs
- run:
name: Test plotly bundles against es6
command: npm run no-es6-dist
command: npm run no-es2017-dist
- run:
name: Display function constructors in all bundles
command: npm run no-new-func
Expand Down
2 changes: 1 addition & 1 deletion .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"eslint:recommended"
],
"parserOptions": {
"ecmaVersion": 5
"ecmaVersion": 2016
},
"env": {
"commonjs": true
Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ To see all merged commits on the master branch that will be part of the next plo

where X.Y.Z is the semver of most recent plotly.js release.

## [next-major]

### Breaking
- Bump build target from ES5 to ES2016, and drop IE support [[#7017](https://github.com/plotly/plotly.js/pull/7017)]

## [2.33.0] -- 2024-05-29

### Added
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"no-new-func": "eslint --no-ignore --no-eslintrc --no-inline-config --rule '{no-new-func: warn}' $(find dist -type f -iname '*.js')",
"no-bad-char": "eslint --no-ignore --no-eslintrc --no-inline-config --rule '{no-misleading-character-class: error}' $(find dist -type f -iname '*.js' | grep plotly)",
"no-dup-keys": "eslint --no-ignore --no-eslintrc --no-inline-config --rule '{no-dupe-keys: error}' $(find dist -type f -iname '*.js' | grep plotly)",
"no-es6-dist": "node tasks/no_es6_dist.js",
"no-es2017-dist": "node tasks/no_es2017_dist.js",
"pretest": "node tasks/pretest.js",
"test-jasmine": "karma start test/jasmine/karma.conf.js",
"test-mock": "node tasks/test_mock.js",
Expand Down
2 changes: 1 addition & 1 deletion stackgl_modules/webpack.config.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
var path = require('path');

module.exports = {
target: ['web', 'es5'],
target: ['web', 'es2016'],
entry: './main.js',
output: {
path: path.resolve('.'),
Expand Down
2 changes: 1 addition & 1 deletion tasks/no_es6_dist.js → tasks/no_es2017_dist.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ function assertES5() {
ignore: false,
overrideConfig: {
parserOptions: {
ecmaVersion: 5
ecmaVersion: 2016
}
}
});
Expand Down
2 changes: 1 addition & 1 deletion test/jasmine/karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ func.defaultConfig = {
},

webpack: {
target: ['web', 'es5'],
target: ['web', 'es2016'],
module: {
rules: webpackConfig.module.rules
},
Expand Down
2 changes: 1 addition & 1 deletion webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ var path = require('path');
var NodePolyfillPlugin = require('node-polyfill-webpack-plugin');

module.exports = {
target: ['web', 'es5'],
target: ['web', 'es2016'],
entry: './lib/index.js',
output: {
path: path.resolve('./build'),
Expand Down