Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using basic auth for proxy tunnel #1133

Merged
merged 2 commits into from
Aug 31, 2018
Merged

Using basic auth for proxy tunnel #1133

merged 2 commits into from
Aug 31, 2018

Conversation

imscaradh
Copy link
Contributor

This is a PR for using Plotly behind a corporate firewall with basic authentication. Although server and port were respected, the basic auth string inside environment variables like $http_proxy is ignored at this stage.

(My question here: #1129)

@jonmmease jonmmease merged commit 4a8a09f into plotly:master Aug 31, 2018
@jonmmease jonmmease added this to the v3.2.0 milestone Aug 31, 2018
@jonmmease
Copy link
Contributor

Thanks @imscaradh!

I finally got a couple of VMs setup in a proxy configuration to try this out, and it works great! I'm going to follow up with a commit to support the upper case versions of each of the proxy environment variables, since that tripped me up a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants