Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandas datetime and numpy numeric array fixes #1163

Merged
merged 3 commits into from
Sep 8, 2018
Merged

Pandas datetime and numpy numeric array fixes #1163

merged 3 commits into from
Sep 8, 2018

Conversation

jonmmease
Copy link
Contributor

  1. Preserve numeric numpy types as-is in validator output, even if that
    numeric type is not supported as JavaScript TypedArray.
  2. Update widget serializer to check numeric numpy arrays for whether
    they are compatible with TypedArrays. If not, serialize as list.
  3. Call to_pydatetime() on pandas datetime series/index values
    when passed to copy_to_readonly_numpy_array. This returns numpy
    array of datetimes (which we already know how to serialize)
  4. Add new _plotly_utils/tests/validators/test_pandas_series_input.py test suite

Fixes datetime issue in #1160 (cc @VelizarVESSELINOV)
Fixes FigureWidget issue in #1155

 1) Preserve numeric numpy types as is in validator out, even if that
    numeric type is not supported as JavaScript TypedArray
 2) Update widget serializer to check numeric numpy arrays for whether
    they are compatible with TypedArrays. If not, serialize as list.
 3) Call to_pydatetime() on pandas datetime series/index values
    when passed to copy_to_readonly_numpy_array. This returns numpy
    array of datetimes (which we already know how to serialize)

Fixes datetime issue in #1160
Fixes FigureWidget issue in #1155
@jonmmease jonmmease added this to the v3.2.1 milestone Sep 8, 2018
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant