Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass config object to iplot when rendering plotly JSON #1281

Merged
merged 3 commits into from
Nov 22, 2018

Conversation

gnestor
Copy link
Contributor

@gnestor gnestor commented Nov 21, 2018

This fixes an issue where users render a Plotly chart to a Jupyter Notebook or JupyterLab (using Plotly JSON and @jupyterlab/plotly-extension vs. plotly.offline.init_notebook_mode) but they're custom Plotly config is not passed to plotly.js (e.g. plotly_domain and plotly_streaming_domain).

Demo notebook:

@jonmmease
Copy link
Contributor

Thanks @gnestor,

@bpostlethwaite @charleyferrari I'll test this out for regressions. Could you look it over and try it out against an on-prem instance?

@bpostlethwaite
Copy link
Member

We will thanks @jonmmease !

@charleyferrari
Copy link

👍 This is working for me with buildly!

@jonmmease
Copy link
Contributor

Looks good, thanks @gnestor

@jonmmease jonmmease merged commit 579d823 into plotly:master Nov 22, 2018
michaelbabyn pushed a commit to michaelbabyn/plotly.py that referenced this pull request Dec 22, 2018
* Pass config object to iplot when rendering plotly JSON
* Pass config file contents by default
* Pass plotly_domain as plotlyServerURL to front-end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants