Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convenience methods for annotations, shapes, and images #1817

Merged
merged 8 commits into from
Oct 15, 2019

Conversation

jonmmease
Copy link
Contributor

Overview

This PR adds a set of new convenience methods for annotations, shapes, and images

  • fig.add_*
  • fig.select_*
  • fig.for_each_*
  • fig.update_*

Where * is annotation(s), shape(s), or image(s).

cc @nicolaskruchten

@jonmmease jonmmease added this to the v4.2.0 milestone Oct 14, 2019
@nicolaskruchten
Copy link
Contributor

Possible issue: we’re going to have an ‘image’ trace type before long so there would be a conflict around add_image... should we use add_layout_image?

@jonmmease
Copy link
Contributor Author

Oh, good point. Thanks for catching that! I'm fine with add_layout_image/select_layout_images/etc. Should we do the same for shapes and annotations or treat image as a special case?

@nicolaskruchten
Copy link
Contributor

Tough call but I think special case for image makes the most sense to me. There isn’t and likely won’t be a non-layout annotation or shape...

@jonmmease
Copy link
Contributor Author

Renamed in fd0ae43

@nicolaskruchten
Copy link
Contributor

Looks good, let's merge it and I'll QA the whole thing this afternoon? 💃

@jonmmease jonmmease merged commit 240d0b4 into master Oct 15, 2019
@jonmmease jonmmease deleted the update_annotations branch October 15, 2019 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants