Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move imshow closer to px pattern #1885

Merged
merged 3 commits into from
Nov 8, 2019
Merged

Move imshow closer to px pattern #1885

merged 3 commits into from
Nov 8, 2019

Conversation

nicolaskruchten
Copy link
Contributor

@emmanuelle here's the first pass on the PX-ification of the imshow function. I'm realizing that to align better with the other px methods we should probably add height, width and template and the rest of the px defaulting machinery...

@nicolaskruchten
Copy link
Contributor Author

Here I've bolted on the applicable parts of the "defaults cascade" logic for which I added a test suite the other day :)

@nicolaskruchten
Copy link
Contributor Author

This lets us do stuff like this:

image

@emmanuelle
Copy link
Contributor

💃 when the CI is green. Which reminds me that we should add imshow examples to the percy test file, one with single-channel and one with RGB. If you don't want to add it here (I should have done this in the initial PR) I'll make another PR for this.

@nicolaskruchten
Copy link
Contributor Author

Ah right yes... If you could do it that would be great :)

@nicolaskruchten nicolaskruchten merged commit 60b0f69 into master Nov 8, 2019
@nicolaskruchten
Copy link
Contributor Author

Ah drat also we need to tweak the PR in py-docs

@nicolaskruchten nicolaskruchten deleted the imshow_px branch June 19, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants