Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix validate_executable behavior #1915

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Fix validate_executable behavior #1915

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/python/plotly/plotly/io/_orca.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1384,11 +1384,10 @@ def ensure_server():
"""
)

# Validate orca executable
if status.state == "unvalidated":
validate_executable()

if not config.server_url:
# Validate orca executable only if server_url is not provided
if status.state == "unvalidated":
validate_executable()
# Acquire lock to make sure that we keep the properties of orca_state
# consistent across threads
with orca_lock:
Expand Down