Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

px.NO_COLOR #2614

Merged
merged 9 commits into from
Jul 8, 2020
Merged

px.NO_COLOR #2614

merged 9 commits into from
Jul 8, 2020

Conversation

nicolaskruchten
Copy link
Contributor

@nicolaskruchten nicolaskruchten commented Jul 4, 2020

Code PR

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the codegen files and not generated files.
  • I have added tests (if submitting a new feature or correcting a bug) or
    modified existing tests.
  • For a new feature, I have added documentation examples in an existing or
    new tutorial notebook (please see the doc checklist as well).
  • I have added a CHANGELOG entry if fixing/changing/adding anything substantial.

@nicolaskruchten nicolaskruchten added this to the 4.9.0 milestone Jul 4, 2020
@nicolaskruchten
Copy link
Contributor Author

@emmanuelle the CI failure actually is material, and seems to be #2618

@nicolaskruchten
Copy link
Contributor Author

(but not due to this PR as far as I can tell, so we should not consider it a PR blocker IMO)

@emmanuelle
Copy link
Contributor

Looks good to me but we could add documentation examples:

import plotly.express as px
df = px.data.experiment(indexed=True)
fig = px.line(df, y=['experiment_1', 'experiment_2'], facet_row='variable', color=px.NO_COLOR)
fig.show()

for NO_COLOR, and an example in subplots.md for the spacing parameters. Do you want to add them here or to open an issue for this? Otherwise 💃

@nicolaskruchten
Copy link
Contributor Author

I'll document the spacing params here. I already have one NO_COLOR doc example, do you think we need a second one?

@emmanuelle
Copy link
Contributor

Sorry between the beginning and the end of the review I had forgotten about the NO_COLOR example :-).

Was it intentional to add px.timeline in the same PR?

@nicolaskruchten
Copy link
Contributor Author

Yeah, although I probably should be a bit more disciplined. I added base to bar in this one too as prep for timeline

@nicolaskruchten
Copy link
Contributor Author

OK, I've stripped out the bar base and timeline stuff into #2626

@nicolaskruchten
Copy link
Contributor Author

still need a little bit of docs in this PR

title="Life Expectancy in Africa")
fig.for_each_annotation(lambda a: a.update(text=a.text.split("=")[-1]))
fig.update_yaxes(showticklabels=True)
fig.show()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great example!

@emmanuelle
Copy link
Contributor

💃 when CI is green (but 3.7-orca)

@nicolaskruchten nicolaskruchten merged commit 29eee77 into master Jul 8, 2020
@nicolaskruchten nicolaskruchten deleted the nocolor branch July 20, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants