Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing layout shape line dash validator #3375 #3609

Closed
wants to merge 3 commits into from

Conversation

dvd7587
Copy link

@dvd7587 dvd7587 commented Mar 1, 2022

Code PR

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the codegen files and not generated files.
  • I have added tests (if submitting a new feature or correcting a bug) or
    modified existing tests.
  • For a new feature, I have added documentation examples in an existing or
    new tutorial notebook (please see the doc checklist as well).
  • I have added a CHANGELOG entry if fixing/changing/adding anything substantial.
  • For a new feature or a change in behaviour, I have updated the relevant docstrings in the code to describe the feature or behaviour (please see the doc checklist as well).

@nicolaskruchten
Copy link
Contributor

Thanks for this pull request! Unfortunately, it was modifying auto-generated code and the full fix needs to be done "upstream" in the code generation machinery. I've implemented a more general fix in #3722 so I'll close this PR now.

@dvd7587
Copy link
Author

dvd7587 commented May 12, 2022

Thanks for this pull request! Unfortunately, it was modifying auto-generated code and the full fix needs to be done "upstream" in the code generation machinery. I've implemented a more general fix in #3722 so I'll close this PR now.

@nicolaskruchten sorry I was not sure, even if I suspected it. thanks for fixing the issue ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants