-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Px pandas2 #4190
Merged
Merged
Px pandas2 #4190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OK that test was a little naive, if nothing else because the figure gets a UUID as its div ID. I'll fix that in the morning and add a changelog |
This was referenced May 5, 2023
Looks good to me 💃 |
LiamConnors
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4179
Fixes #4065
Pandas v2.0 removed
df.append
, need to change topd.concat
. Note thatpd.concat
has been available since at least v0.13 so there should be no issue with older versions requiring that we usedf.append
.Tested by having the
px
Percy tests generate the same HTML files with bothpandas==1.1.5
(the oldest version with a Py3.9 wheel) andpandas==2.0.1
(latest) and check that the HTML is identical before shipping it off to Percy.plotly.graph_objects
, my modifications concern thecodegen
files and not generated files.modified existing tests.