Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyterlab v4 take2 #4227

Merged
merged 4 commits into from
Jun 3, 2023
Merged

Jupyterlab v4 take2 #4227

merged 4 commits into from
Jun 3, 2023

Conversation

alexcjohnson
Copy link
Collaborator

@alexcjohnson alexcjohnson commented Jun 2, 2023

Putting #4217 on hold for now since I still have not managed to update any local env I create to Jupyterlab 4 successfully, let's go a different route: take from #4217 the fix that I think will work for jupyterlab 4 3b4b324 and the little setup fix 411d66a, but pin our build process to jupyterlab 3 for now 8df887d. Turns out a full upgrade of the process to jupyterlab 4 entails also upgrading the build pipeline from Python 3.7 to 3.8 or later, so a bigger and riskier project than I want right now, and I can't find good information about whether the upgraded version of the extension will work with older versions of jupyterlab anyway.

Fortunately even for jupyterlab 3 users this change has a benefit: we previously set 360px as the minimum output height, but with this change that's just the default, if you set a smaller height that's what you'll get.

  • I have added a CHANGELOG entry if fixing/changing/adding anything substantial.

@WenjieZ
Copy link
Contributor

WenjieZ commented Aug 2, 2023

Hi, has this bugfix been integrated in a release? I encountered the same problem in 5.15.0.

@alexcjohnson
Copy link
Collaborator Author

@WenjieZ yes this fix is part of 5.15.0. Jupyter is notorious for having multiple versions installed, you can confirm this is actually being rendered by 5.15 as it will have plotly.js v2.24.1 if you hover on the Plotly logo on a graph. (5.16 released last week has plotly.js v2.25.2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants