Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing config bug in #589 #601

Closed
wants to merge 1 commit into from
Closed

fixing config bug in #589 #601

wants to merge 1 commit into from

Conversation

gte620v
Copy link

@gte620v gte620v commented Nov 3, 2016

#589 changed the argument signature of _plot_html. This PR fixes the two calls to that function.

See #399 (comment)

@gte620v
Copy link
Author

gte620v commented Nov 3, 2016

It looks like #410 might fix this as well.

@Kully
Copy link
Contributor

Kully commented Nov 3, 2016

It looks like #410 might fix this as well.

There are so many open PRs to this it looks like. I made this one #599 yesterday. The same as yours except for an additional PEP-8 thing (I indented the content of some tuple of config_keys and didn't replace the show_link and link_text keys in the plot call.

@gte620v
Copy link
Author

gte620v commented Nov 3, 2016

@Kully Yeah, same idea. Feel free to close this one if you have it under control.

@Kully Kully closed this Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants