Clearing data list #900
Closed
Clearing data list #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi all, I was playing around with gantt charts and experience that the legend (colorbar) needs to be scrolled to see my defined 'Tasks' at the very bottom (which is actually visible at the examples as well, above the 'Tasks' are hidden traces, which are even clickable). After checking through _gantt.py I identified following two rows, where the variable 'data' has many entries (why this is I could not tell precisely). However, clearing this data list showed only the 'Tasks' at the colorbar: new line 277: adding 'data=[]' to clear the filled list data to display only 'Tasks' and not many hidden trace entries. same applies for row 359 same apploes for row 517 Can you please verify and if you agree, push the change to the repo? Many thanks Cheers J
jackparmer
reviewed
Jan 22, 2018
| @@ -274,7 +274,10 @@ def gantt_colorscale(chart, colors, title, index_col, show_colorbar, bar_width, | |||
|
|
|||
| if show_colorbar is True: | |||
| # generate dummy data for colorscale visibility | |||
| data.append( | |||
| datalisted = data | |||
There was a problem hiding this comment.
For readability, can we changed newentries and datalisted to new_entries and data_listed?
There was a problem hiding this comment.
sure, underscores or none or naming conventions, I am good with any.
|
@mokaithered I'm trying to replicate this legend issue with the hidden traces, but can't find an example, can you please drop a screenshot or GIF here? |
|
I hope this helps! Sorry for the grey areas, I need to be a bit careful concerning the data. You can also check the example posted at the official website for plotly gantt charts. Those gantt charts have the same issue. Cheers ---edits--- |
|
Extra space in Gantt-chart legend issue was resolved by #1110 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I was playing around with gantt charts and experience that the legend (colorbar) needs to be scrolled to see my defined 'Tasks' at the very bottom (which is actually visible at the examples as well, above the 'Tasks' are hidden traces, which are even clickable). After checking through _gantt.py I identified the following rows, where the variable 'data' has many entries.
new lines @ 277
new lines @ 359
new lines @ 517
Can someone please verify and if agreeing, pushing the change to the repo?
Many thanks
Cheers
J
---edit---
found some issue and had to fix this