Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add refresh image button #3

Merged
merged 1 commit into from
May 24, 2014
Merged

Add refresh image button #3

merged 1 commit into from
May 24, 2014

Conversation

freemanoid
Copy link

Every captcha have a possibility to update the current picture by clicking on it our via special refresh button.

I have added the refresh button to simple_captcha.
The one current requirement is that we need to have jquery_ujs on the page with captcha. I don't know how to include it via simple-captcha correctly (we need to include jquery_ujs if it hasn't included on this page already)

@zealot128
Copy link
Member

thanks @freemanoid for the contribution, that would be quite an improvement.

I started to add some basic tests for simple captcha. Do you think, it will be possible, to add some basic tests that cover the new functionality?
Maybe we will just tell in the README that jquery_ujs is required. Maybe later will can make a switch/config option for setting the Refresh button. What do you think?

@freemanoid
Copy link
Author

I'll add some tests and attach to this issue when it will be done.

@freemanoid freemanoid closed this May 13, 2014
@zealot128 zealot128 reopened this May 24, 2014
@zealot128 zealot128 merged commit cc68800 into pludoni:master May 24, 2014
@zealot128
Copy link
Member

Thanks for all the ground work. I merged the changes and made the tests pass, which fail because of a missing session. Besides, I tried to generalize the captcha image id because of #8.
It is on master now, but I didn't released a new gem yet. If you have some time, can you try this new release with your app?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants