change composer action for deployment workflows #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous composer action adds some extra files to the project root. Those can be ignored, but the action used for testing is fast and allows to specify the exact PHP version whereas the composer action uses the latest stable.
stklcode
changed the title
|
Can anyone with composer knowledge/opinion help here? @pfefferle, @2ndkauboy , @florianbrinkmann or @patrickrobrecht ? If a second pair of eyes had a look I can merge this. |
|
What about downloading the required composer as phar version? |
|
And/or it seems possible to downgrade composer with for example |
|
The action in use is capable of doing that, if necessary (docs) Just use |
stklcode
added a commit
that referenced
this pull request
Oct 28, 2021
The previous composer action adds some extra files to the project root. Those can be ignored, but the action used for testing is fast and allows to specify the exact PHP version whereas the composer action uses the latest stable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous composer action adds some extra files to the project root. This PR resolves #218.
Those can be ignored, but the action used for testing is fast and allows to specify the exact PHP version whereas the composer action uses the latest stable (we stumbled upon this in other projects).
The
shivammathur/setup-php@v2version has proven to work since #217, so why not use the same workflow in all 3 recipes...