Cache exceptions/User-Agents translation #52
Conversation
|
@timse201 please review this pull request more for the codex, use blanks after a open and closed brackets, like current |
| @@ -1605,8 +1605,8 @@ private static function _minify_select() | |||
| { | |||
| return array( | |||
| self::MINIFY_DISABLED => esc_html__('No minify', 'cachify'), | |||
| self::MINIFY_HTML_ONLY => 'HTML', | |||
| self::MINIFY_HTML_JS => 'HTML + Inline JavaScript' | |||
| self::MINIFY_HTML_ONLY => esc_html__('HTML', 'cachify'), | |||
There was a problem hiding this comment.
Please, I will buy a blank for esc_html__( 'HTML', 'cachify' ),, before and after brackets.
| @@ -1776,14 +1776,14 @@ public static function options_page() | |||
| <fieldset> | |||
| <label for="cachify_without_ids"> | |||
| <input type="text" name="cachify[without_ids]" id="cachify_without_ids" value="<?php echo esc_attr($options['without_ids']) ?>" /> | |||
| Post/Pages-IDs | |||
| __('Post/Pages-IDs (separated by commas)', 'cachify' ); | |||
There was a problem hiding this comment.
Also here, I will buy a blank tp esc_html__( ' and a filter function to sanitize the input string.
|
Really great, thanks a lot for the effort. |
|
@timse201 can you enhance the CHANGELOG.md with your changes, for the headline |
No description provided.