Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementation of config hints; some restructure; donation link #69

Merged
merged 52 commits into from
Feb 13, 2017
Merged

implementation of config hints; some restructure; donation link #69

merged 52 commits into from
Feb 13, 2017

Conversation

timse201
Copy link
Contributor

@timse201 timse201 commented Jan 26, 2017

what i changed:

  • the ui is now more or less in separate files
  • added a navbar
  • paypal to donate; support link added; updated paypal link (as discussed on slack)
  • deleted unnecessary valign and inline styles
  • enhanced error message (the HTML code for the info symbol will be replaced by WordPress and a svg img is displayed)

to do list:

  • nginx needs to be tested - will it include the right page? I have no test platform to do that
  • your thoughts ;)

#27 #32 #39 #68

@timse201 timse201 changed the title early implementation of config hints implementation of config hints Jan 27, 2017

error_page 405 = @nocache;

try_files /wp-content/cache/cachify/https-${host}${uri}index.html /wp-content/cache/cachify/${host}${uri}index.html @nocache;
Copy link
Contributor Author

@timse201 timse201 Jan 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wp_make_link_relative( content_url( $path ) ) needed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you tried this? Currently without testing I don't know.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean try files? I didnt test this. I have no nginx server. But this code was posted by swispydy on GitHub in an issue (sry I'm on a mobile device). And the user posted this code on his website so the code should work.
My thought behind all this is we should include standard configs that work for every server with less notes so a standard user is not confused. If someone wants specific code for HTTP or HTTPS only he can look into the wiki. But if we try to include 3 different configs it will confuse all users that are new with such things

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I mean have try with your idea to use content_url( $path ) .

Copy link
Contributor Author

@timse201 timse201 Feb 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh OK
True - wp_make_link_relative( content_url( $path ) ), should be the right one
Do we need this code phrase here to print the right path - for these both code lines?

}

## PROTECT CACHE
location ~ /wp-content/cache {
Copy link
Contributor Author

@timse201 timse201 Jan 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wp_make_link_relative( content_url( $path ) ) needed?

@timse201 timse201 changed the title implementation of config hints; some restructure implementation of config hints; some restructure; donation link Jan 30, 2017
@bueltge bueltge merged commit e2f132c into pluginkollektiv:master Feb 13, 2017
@bueltge
Copy link
Member

bueltge commented Feb 13, 2017

Should great and helpful, but we need a test about different installs.

@timse201 timse201 deleted the patch-2 branch March 8, 2017 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants