Switch to recursive subdomains instead of hyphens #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Easy and customizable dashboards for your build system. Learn more about Stoat ↗︎ Static Hosting
Job Runtime |
michaeljguarino
force-pushed
the
better-cloud-subdomaining
branch
2 times, most recently
from
585eb89
to
39256d4
Compare
maciaszczykm
approved these changes
Aug 21, 2024
michaeljguarino
force-pushed
the
better-cloud-subdomaining
branch
from
39256d4
to
ca55670
Compare
Mostly an aesthetic change, but I think i figured out what was happening w/ externaldns here.
michaeljguarino
force-pushed
the
better-cloud-subdomaining
branch
from
ca55670
to
e97eee4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly an aesthetic change, but I think i figured out what was happening w/ externaldns here.
Test Plan
regressikon
Checklist