Skip to content
This repository has been archived by the owner on Mar 22, 2023. It is now read-only.

tests: add suppression for memcheck #1263

Open
wants to merge 3 commits into
base: stable-1.13
Choose a base branch
from

Conversation

lukaszstolarczuk
Copy link
Member

@lukaszstolarczuk lukaszstolarczuk commented Jul 21, 2022

ref. #1262


This change is Reviewable

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #1263 (fb91098) into stable-1.13 (f49772a) will decrease coverage by 1.78%.
The diff coverage is 69.04%.

❗ Current head fb91098 differs from pull request most recent head 7a78bb5. Consider uploading reports for the commit 7a78bb5 to get more accurate results

@@               Coverage Diff               @@
##           stable-1.13    #1263      +/-   ##
===============================================
- Coverage        95.52%   93.74%   -1.79%     
===============================================
  Files               53       53              
  Lines             6755     4573    -2182     
===============================================
- Hits              6453     4287    -2166     
+ Misses             302      286      -16     
Flag Coverage Δ
tests_clang_debug_cpp17 93.46% <68.96%> (-1.66%) ⬇️
tests_gcc_debug 90.37% <74.22%> (-2.00%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/libpmemobj++/allocator.hpp 71.42% <0.00%> (-7.82%) ⬇️
include/libpmemobj++/condition_variable.hpp 72.97% <0.00%> (-7.42%) ⬇️
include/libpmemobj++/container/array.hpp 97.33% <ø> (-0.80%) ⬇️
include/libpmemobj++/container/basic_string.hpp 98.69% <ø> (-0.63%) ⬇️
...j++/container/detail/concurrent_skip_list_impl.hpp 96.69% <ø> (-1.02%) ⬇️
include/libpmemobj++/container/segment_vector.hpp 93.15% <ø> (-2.30%) ⬇️
include/libpmemobj++/detail/ebr.hpp 95.74% <ø> (-2.89%) ⬇️
include/libpmemobj++/detail/pair.hpp 100.00% <ø> (ø)
include/libpmemobj++/detail/tagged_ptr.hpp 100.00% <ø> (ø)
include/libpmemobj++/detail/temp_value.hpp 100.00% <ø> (ø)
... and 68 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@igchor igchor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: but this should be opened against stable-1.13 I think (@kilobyte reported the issue for 1.13)

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @lukaszstolarczuk)

@lukaszstolarczuk lukaszstolarczuk changed the base branch from master to stable-1.13 July 21, 2022 11:15
@lukaszstolarczuk
Copy link
Member Author

this should be opened against stable-1.13 I think (@kilobyte reported the issue for 1.13)

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @lukaszstolarczuk)

good point, re-based.

@lukaszstolarczuk
Copy link
Member Author

I had to add a commit (cherry-picked from master) with the PMDK version update, due to CI failure.

@lukaszstolarczuk lukaszstolarczuk marked this pull request as draft July 22, 2022 11:48
@kilobyte
Copy link
Contributor

WFM.
Tagged and bagged.

@lukaszstolarczuk lukaszstolarczuk added this to the 1.13 milestone Jul 25, 2022
@lukaszstolarczuk lukaszstolarczuk force-pushed the add-memcheck-supp branch 2 times, most recently from c8a90ca to f5aba20 Compare July 25, 2022 13:51
@lukaszstolarczuk
Copy link
Member Author

lukaszstolarczuk commented Jul 25, 2022

for this PR to work (and the whole stable-1.13 branch), we'd have to apply 2 CI fixes: Windows workflow update and the newest PMDK installed (both cherry-picked here). I'm not sure if we want (and need) to do this now - we're applying these fixes into stable-1.9, and we can wait for them to be merged, bottom to top.

Copy link

@Karolina002 Karolina002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @lukaszstolarczuk)

Copy link

@karczex karczex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @lukaszstolarczuk)

@lukaszstolarczuk lukaszstolarczuk marked this pull request as ready for review September 16, 2022 10:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants