Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic retry on Gateway Timeout errors #1053

Merged
merged 1 commit into from
Feb 6, 2020

Conversation

mrebuffet
Copy link

Category

  • Bug fix?
  • [ X] New feature?
  • New sample?
  • Documentation update?

Related Issues

fixes #1048

What's in this Pull Request?

  • Automatic retry of http requests that failed with a Gateway Timeout (504) error.
    Added this change in both the SPHttpClient and the GraphHttpClient classes.

@mrebuffet mrebuffet changed the title Retry on Gateway Timeout errors Automatic retry on Gateway Timeout errors Feb 5, 2020
@patrick-rodgers patrick-rodgers added this to the 2.0.3 milestone Feb 5, 2020
@patrick-rodgers
Copy link
Member

Thanks @mrebuffet - appreciate you submitting these updates and including the fix for both branches! Nice work

@patrick-rodgers patrick-rodgers merged commit a312388 into pnp:version-2 Feb 6, 2020
@mrebuffet mrebuffet deleted the ops/retryGatewayTimeoutV2 branch February 6, 2020 22:02
@mrebuffet mrebuffet restored the ops/retryGatewayTimeoutV2 branch April 5, 2020 22:56
@mrebuffet mrebuffet deleted the ops/retryGatewayTimeoutV2 branch June 10, 2021 01:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retry on Gateway Timeout (504) errors
2 participants