This repository has been archived by the owner on Jun 29, 2020. It is now read-only.
(Freature) Add ERC-735 claim generation + PoPA ERC-725 Contract #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove jquery minified file from public folder.
…contract-component
Make server-lib/sign function return extra data needed for the erc-725/erc-735 signature and claim generation.
Add the corresponding controller, env variables and config modifications.
Add basic route spec. Add is_address_confirmed spec. Add server/lib/is_address_confirmed.
…y-page (Feature) "Add claim to identity" page
Move signature generation code out of issueErc725Claim controller. Move erc725 URI constant to config/env file. Add issueErc725Cliam.spec.js with validation specs.
Fix naming parts of the code that handle erc735 claim generation code (previously named with "erc735 something", which was too general). Fix tests accordingly.
Add ProofOfPhysicalAddressKeyHolder.sol which is a KeyHolder contract (taken from Origin's playground repo). Add test for ProofOfPhysicalAddressKeyHolder.sol (also taken from Origin's playgorund repo).
Add removeKey tests to proof_of_physical_address_key_holder_spec.js. Add signer management to ProofOfPhysicalAddressKeyHolder + tests.
…to-identity-page-improvements
…d-contracts' into add-claim-to-identity-page-improvements
Modify AddClaimToIdentityPage to show erc735 claim data generated. Add a button to explicitly add the erc735 to the erc725 identity contract. Update tests.
ghost
assigned 
|
Just in case, I have just performed the following:
|
|
@phahulin friendly ping 😬 |
|
I think it's best if we stay with two contracts without the need to upgrade existing PoPA contract. |
phahulin
approved these changes
Dec 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration branch that includes the code from PRs #208 , #209 + some UI improvements on the ERC-735 claim generation page.
@phahulin one thing that it is still pending:
The reason:
The not so good thing about this is that the address of the "PoPA identity contract" (the address that appears on the
issuerfield of the ERC-735 claims, and that I highlight in the demo below) holds the address ofProofOfPhysicalAddressKeyHolder.soland not the mainProofOfPhysicalAddress.sol. I'm not really sure if this is a_bad thing_ but we end up with 2 contracts... [1]@phahulin do you have an opinion on the above? May be we could try a refactor using Solidity's
delegatecall, or some other pattern, so we end up with a unique contract that has everything: previous features + new identity/key holder features.Short demo:
NOTES:
ProofOfPhysicalAddress.solwas the compiler version so, in theory, we should not need to upgrade/redeploy it.