Percentile filter #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added some unit tests to support refactoring
This exposion implementation is compatible with both Netty 4.0 and 4.1. This also makes it possible to use the same exposion implementation for Cassandra 4.0 as well as legacy versions. Closes #39
Add unit test to demonstrate issue #46 Closes #47
Closes #38
Closes #52
…orter into eperott-leak_utest
…-exporter into eperott-nio_exposition
…luation
Closes #27.
Squashed commit of the following:
commit c8eafefc7732d84114c990f81d6ad70489dafcec
Author: Adam Zegelin <adam@zegelin.com>
Date: Fri Feb 21 15:20:55 2020 -0800
Code cleanup.
commit 425df4699f963213c5498b3f1eedec5fdb38a609
Merge: 0b5e2c0 21307ab
Author: Adam Zegelin <adam@zegelin.com>
Date: Fri Feb 21 15:11:05 2020 -0800
Merge branch 'fix-mbean-jmx-harvester' of https://github.com/suhailpatel/cassandra-exporter into suhailpatel-fix-mbean-jmx-harvester
commit 21307ab
Author: Suhail Patel <me@suhailpatel.com>
Date: Tue Jul 9 16:46:24 2019 +0100
Dynamically update the set of current MBeans as we go along
Again, if exceptions occur in other parts of the pipeline, MBeans are
registered but are not removed which causes other bugs.
Note that we use an immutable copy of the sets because the currentMBeans
set is being updated constantly.
commit c4b46dc
Author: Suhail Patel <me@suhailpatel.com>
Date: Sat Jul 6 20:51:06 2019 +0100
Add exception handling for MBean disappearing between listing and evaluation
There was a condition where evaluating the set of added MBean can cause
an exception. This would occur if the MBean had disappeared between
listing the MBean and extracting the MBean info. If this happened in the
middle of a set of added MBeans, it would mean our current MBeans set in
the JMXHarvester isn't up to date with the current MBeans.
This has cascading impact down the line because there are MBeans
registered from previous runs that are not correctly associated with the
set of current MBeans. This means they will never be cleaned up. This
has impact on the collect stage which then results in other exceptions.
We found this occur during Repair jobs when the repair durations are
very small.
Enhanced code to filter quantiles based on user choice Included --cql-ssl option to crated encrypted native connection Added latest version of jars as the older version are having some vulnerabilities
Used netty 4.1.42.Final to be inline with another PR
…le-filter The master branch contains some important fixes.
Applied quantile filtering while writing metrics into socket. Corrected formating. Reverted netty jar version changes.
Appended the new line at the end of files which removed while restoring previous changes from repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.