Pods 3.2.8 #7347

PodsBot · 2024-08-31T01:26:11Z

Automated changes by create-pull-request GitHub action

what-the-diff · 2024-08-31T01:26:27Z

PR Summary

Updated Coding Standards
The former coding standards used in the project, TribalScents, were replaced with the StellarWP standard. As part of this change, some rules were also excluded.
Changed dependencies
The project no longer depends on "the-events-calendar/coding-standards". Instead, it now utilizes "stellarwp/coding-standards".
Improved Functionality in 'general.php'
The pods_shortcode_run function has been updated to increase its reliability when assigning variables and checking conditions.
Version Upgrade
The plugin, as well as the version in the package.json file and the stable tag version in the readme.txt, were all upgraded from 3.2.7 to 3.2.8-a-1.
Added Content Formatting Option in 'Base.php'
A method, should_autop, was implemented to decide whether the wpautop (a function that automatically adds line breaks and paragraph tags to text) should be applied to block content output.
Enhanced Content Rendering in 'Field.php', 'Item_List.php', and 'Related_Item_List.php'
The render method in these files now calls the previously mentioned should_autop method when determining how to format the content.

…Pods object is not returned

PodsBot

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

phpcs

[phpcs] _{reported by reviewdog 🐶}
PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
Public method name "Base::should_autop" is not in camel caps format

pods/src/Pods/Blocks/Types/Base.php

Line 284 in 8b99c43

public function should_autop( $content, array $attributes = [] ): bool {

[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionDeclaration.BraceOnSameLine
Opening brace should be on a new line

pods/src/Pods/Blocks/Types/Base.php

Line 284 in 8b99c43

public function should_autop( $content, array $attributes = [] ): bool {

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 285 in 8b99c43

$should_autop = (

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 286 in 8b99c43

is_string( $content )

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 287 in 8b99c43

&& false === strpos( $content, '<div' )

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 288 in 8b99c43

&& false === strpos( $content, '<ul' )

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 289 in 8b99c43

&& false === strpos( $content, '<ol' )

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 290 in 8b99c43

&& false === strpos( $content, '<h' )

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 291 in 8b99c43

&& false === strpos( $content, '<p' )

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 292 in 8b99c43

);

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 294 in 8b99c43

/**

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 295 in 8b99c43

* Allow filtering whether to apply wpautop to the block content output.

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 296 in 8b99c43

*

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 297 in 8b99c43

    
           		 * This is used for things like Field block render or List block render of the no items found message.

[phpcs] _{reported by reviewdog 🐶}
Generic.Files.LineLength.TooLong
Line exceeds 85 characters; contains 110 characters

pods/src/Pods/Blocks/Types/Base.php

Line 297 in 8b99c43

    
           		 * This is used for things like Field block render or List block render of the no items found message.

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 298 in 8b99c43

*

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 299 in 8b99c43

* @since TBD

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 300 in 8b99c43

*

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 301 in 8b99c43

    
           		 * @param bool         $should_autop Whether to apply wpautop to the block content output.

[phpcs] _{reported by reviewdog 🐶}
Generic.Files.LineLength.TooLong
Line exceeds 85 characters; contains 98 characters

pods/src/Pods/Blocks/Types/Base.php

Line 301 in 8b99c43

    
           		 * @param bool         $should_autop Whether to apply wpautop to the block content output.

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 302 in 8b99c43

* @param string|mixed $content The content to determine whether to autop.

[phpcs] _{reported by reviewdog 🐶}
Generic.Files.LineLength.TooLong
Line exceeds 85 characters; contains 87 characters

pods/src/Pods/Blocks/Types/Base.php

Line 302 in 8b99c43

* @param string|mixed $content The content to determine whether to autop.

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 303 in 8b99c43

    
           		 * @param array        $attributes   The Pods render attributes that will be used.

[phpcs] _{reported by reviewdog 🐶}
Generic.Files.LineLength.TooLong
Line exceeds 85 characters; contains 90 characters

pods/src/Pods/Blocks/Types/Base.php

Line 303 in 8b99c43

    
           		 * @param array        $attributes   The Pods render attributes that will be used.

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 304 in 8b99c43

*/

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 305 in 8b99c43

    
           return (bool) apply_filters( 'pods_blocks_should_autop', $should_autop, $content, $attributes );

[phpcs] _{reported by reviewdog 🐶}
Generic.Files.LineLength.TooLong
Line exceeds 85 characters; contains 104 characters

pods/src/Pods/Blocks/Types/Base.php

Line 305 in 8b99c43

    
           return (bool) apply_filters( 'pods_blocks_should_autop', $should_autop, $content, $attributes );

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 306 in 8b99c43

}

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Field.php

Line 215 in 8b99c43

if ( $this->should_autop( $content, $attributes ) ) {

[phpcs] _{reported by reviewdog 🐶}
PEAR.ControlStructures.MultiLineCondition.SpacingAfterOpenBrace
First condition of a multi-line IF statement must directly follow the opening parenthesis

pods/src/Pods/Blocks/Types/Field.php

Line 215 in 8b99c43

if ( $this->should_autop( $content, $attributes ) ) {

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Item_List.php

Line 429 in 8b99c43

    
           if ( ! empty( $attributes['not_found'] ) && $this->should_autop( $attributes['not_found'] ) ) {

[phpcs] _{reported by reviewdog 🐶}
PEAR.ControlStructures.MultiLineCondition.SpacingAfterOpenBrace
First condition of a multi-line IF statement must directly follow the opening parenthesis

pods/src/Pods/Blocks/Types/Item_List.php

Line 429 in 8b99c43

    
           if ( ! empty( $attributes['not_found'] ) && $this->should_autop( $attributes['not_found'] ) ) {

[phpcs] _{reported by reviewdog 🐶}
Generic.Files.LineLength.TooLong
Line exceeds 85 characters; contains 103 characters

pods/src/Pods/Blocks/Types/Item_List.php

Line 429 in 8b99c43

    
           if ( ! empty( $attributes['not_found'] ) && $this->should_autop( $attributes['not_found'] ) ) {

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Item_List.php

Line 430 in 8b99c43

$attributes['not_found'] = wpautop( $attributes['not_found'], $attributes );

[phpcs] _{reported by reviewdog 🐶}
Generic.Files.LineLength.TooLong
Line exceeds 85 characters; contains 88 characters

pods/src/Pods/Blocks/Types/Item_List.php

Line 430 in 8b99c43

$attributes['not_found'] = wpautop( $attributes['not_found'], $attributes );

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Item_List.php

Line 431 in 8b99c43

}

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Related_Item_List.php

Line 347 in 8b99c43

    
           if ( ! empty( $attributes['not_found'] ) && $this->should_autop( $attributes['not_found'] ) ) {

[phpcs] _{reported by reviewdog 🐶}
PEAR.ControlStructures.MultiLineCondition.SpacingAfterOpenBrace
First condition of a multi-line IF statement must directly follow the opening parenthesis

pods/src/Pods/Blocks/Types/Related_Item_List.php

Line 347 in 8b99c43

    
           if ( ! empty( $attributes['not_found'] ) && $this->should_autop( $attributes['not_found'] ) ) {

[phpcs] _{reported by reviewdog 🐶}
Generic.Files.LineLength.TooLong
Line exceeds 85 characters; contains 103 characters

pods/src/Pods/Blocks/Types/Related_Item_List.php

Line 347 in 8b99c43

    
           if ( ! empty( $attributes['not_found'] ) && $this->should_autop( $attributes['not_found'] ) ) {

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Related_Item_List.php

Line 348 in 8b99c43

$attributes['not_found'] = wpautop( $attributes['not_found'], $attributes );

[phpcs] _{reported by reviewdog 🐶}
Generic.Files.LineLength.TooLong
Line exceeds 85 characters; contains 88 characters

pods/src/Pods/Blocks/Types/Related_Item_List.php

Line 348 in 8b99c43

$attributes['not_found'] = wpautop( $attributes['not_found'], $attributes );

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Related_Item_List.php

Line 349 in 8b99c43

}

PodsBot

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

phpcs

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 285 in 6dee8cc

$should_autop = (

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 286 in 6dee8cc

is_string( $content )

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 287 in 6dee8cc

&& false === strpos( $content, '<div' )

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 288 in 6dee8cc

&& false === strpos( $content, '<ul' )

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 289 in 6dee8cc

&& false === strpos( $content, '<ol' )

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 290 in 6dee8cc

&& false === strpos( $content, '<h' )

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 291 in 6dee8cc

&& false === strpos( $content, '<p' )

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 292 in 6dee8cc

);

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 294 in 6dee8cc

/**

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 295 in 6dee8cc

* Allow filtering whether to apply wpautop to the block content output.

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 296 in 6dee8cc

*

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 297 in 6dee8cc

    
           		 * This is used for things like Field block render or List block render of the no items found message.

[phpcs] _{reported by reviewdog 🐶}
Generic.Files.LineLength.MaxExceeded
Line exceeds maximum limit of 100 characters; contains 110 characters

pods/src/Pods/Blocks/Types/Base.php

Line 297 in 6dee8cc

    
           		 * This is used for things like Field block render or List block render of the no items found message.

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 298 in 6dee8cc

*

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 299 in 6dee8cc

* @since TBD

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 300 in 6dee8cc

*

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 301 in 6dee8cc

    
           		 * @param bool         $should_autop Whether to apply wpautop to the block content output.

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 302 in 6dee8cc

* @param string|mixed $content The content to determine whether to autop.

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 303 in 6dee8cc

    
           		 * @param array        $attributes   The Pods render attributes that will be used.

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 304 in 6dee8cc

*/

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 305 in 6dee8cc

    
           return (bool) apply_filters( 'pods_blocks_should_autop', $should_autop, $content, $attributes );

[phpcs] _{reported by reviewdog 🐶}
Generic.Formatting.NoSpaceAfterCast.SpaceFound
A cast statement must not be followed by a space

pods/src/Pods/Blocks/Types/Base.php

Line 305 in 6dee8cc

    
           return (bool) apply_filters( 'pods_blocks_should_autop', $should_autop, $content, $attributes );

[phpcs] _{reported by reviewdog 🐶}
Generic.Files.LineLength.MaxExceeded
Line exceeds maximum limit of 100 characters; contains 104 characters

pods/src/Pods/Blocks/Types/Base.php

Line 305 in 6dee8cc

    
           return (bool) apply_filters( 'pods_blocks_should_autop', $should_autop, $content, $attributes );

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Base.php

Line 306 in 6dee8cc

}

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Field.php

Line 215 in 6dee8cc

if ( $this->should_autop( $content, $attributes ) ) {

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Item_List.php

Line 429 in 6dee8cc

    
           if ( ! empty( $attributes['not_found'] ) && $this->should_autop( $attributes['not_found'] ) ) {

[phpcs] _{reported by reviewdog 🐶}
Generic.Files.LineLength.MaxExceeded
Line exceeds maximum limit of 100 characters; contains 103 characters

pods/src/Pods/Blocks/Types/Item_List.php

Line 429 in 6dee8cc

    
           if ( ! empty( $attributes['not_found'] ) && $this->should_autop( $attributes['not_found'] ) ) {

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Item_List.php

Line 430 in 6dee8cc

$attributes['not_found'] = wpautop( $attributes['not_found'], $attributes );

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Item_List.php

Line 431 in 6dee8cc

}

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Related_Item_List.php

Line 347 in 6dee8cc

    
           if ( ! empty( $attributes['not_found'] ) && $this->should_autop( $attributes['not_found'] ) ) {

[phpcs] _{reported by reviewdog 🐶}
Generic.Files.LineLength.MaxExceeded
Line exceeds maximum limit of 100 characters; contains 103 characters

pods/src/Pods/Blocks/Types/Related_Item_List.php

Line 347 in 6dee8cc

    
           if ( ! empty( $attributes['not_found'] ) && $this->should_autop( $attributes['not_found'] ) ) {

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Related_Item_List.php

Line 348 in 6dee8cc

$attributes['not_found'] = wpautop( $attributes['not_found'], $attributes );

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

pods/src/Pods/Blocks/Types/Related_Item_List.php

Line 349 in 6dee8cc

}

PodsBot

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

phpcs

[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionCallSignature.SpaceAfterOpenBracket
Space after opening parenthesis of function call prohibited

pods/src/Pods/Blocks/Types/Related_Item_List.php

Line 347 in 06183dd

    
           if ( ! empty( $attributes['not_found'] ) && $this->should_autop( $attributes['not_found'] ) ) {

[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionCallSignature.SpaceBeforeCloseBracket
Expected 0 spaces before closing parenthesis; 1 found

pods/src/Pods/Blocks/Types/Related_Item_List.php

Line 347 in 06183dd

    
           if ( ! empty( $attributes['not_found'] ) && $this->should_autop( $attributes['not_found'] ) ) {

[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionCallSignature.SpaceAfterOpenBracket
Space after opening parenthesis of function call prohibited

pods/src/Pods/Blocks/Types/Related_Item_List.php

Line 347 in 06183dd

    
           if ( ! empty( $attributes['not_found'] ) && $this->should_autop( $attributes['not_found'] ) ) {

[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionCallSignature.SpaceBeforeCloseBracket
Expected 0 spaces before closing parenthesis; 1 found

pods/src/Pods/Blocks/Types/Related_Item_List.php

Line 347 in 06183dd

    
           if ( ! empty( $attributes['not_found'] ) && $this->should_autop( $attributes['not_found'] ) ) {

[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionCallSignature.SpaceAfterOpenBracket
Space after opening parenthesis of function call prohibited

pods/src/Pods/Blocks/Types/Related_Item_List.php

Line 348 in 06183dd

$attributes['not_found'] = wpautop( $attributes['not_found'], $attributes );

[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionCallSignature.SpaceBeforeCloseBracket
Expected 0 spaces before closing parenthesis; 1 found

pods/src/Pods/Blocks/Types/Related_Item_List.php

Line 348 in 06183dd

$attributes['not_found'] = wpautop( $attributes['not_found'], $attributes );

PodsBot · 2024-09-10T04:16:51Z

ui/admin/setup-add.php

+											<?php echo( $submit_from_linked ? 'class="hidden"' : '' ); ?>>
+											<h2 class="pods-wizard-one-click-actions-heading"><?php esc_html_e( 'One-Click Extend', 'pods' ); ?></h2>
+											<ul class="pods-wizard-one-click-actions">
+												<?php foreach ( $quick_actions as $quick_action_key => $quick_action ) : ?>


[phpcs] _{reported by reviewdog 🐶}
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$quick_action_key".

PodsBot · 2024-09-10T04:16:51Z

ui/admin/setup-add.php

+											<?php echo( $submit_from_linked ? 'class="hidden"' : '' ); ?>>
+											<h2 class="pods-wizard-one-click-actions-heading"><?php esc_html_e( 'One-Click Extend', 'pods' ); ?></h2>
+											<ul class="pods-wizard-one-click-actions">
+												<?php foreach ( $quick_actions as $quick_action_key => $quick_action ) : ?>


[phpcs] _{reported by reviewdog 🐶}
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$quick_action".

PodsBot

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

phpcs

[phpcs] _{reported by reviewdog 🐶}
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'pods_v'.

pods/components/Roles/ui/add.php

Line 41 in 6ccfcd8

echo PodsForm::field( 'role_label', pods_v( 'role_label', 'post' ), 'text', [

[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

pods/components/Roles/ui/add.php

Line 41 in 6ccfcd8

echo PodsForm::field( 'role_label', pods_v( 'role_label', 'post' ), 'text', [

[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

pods/components/Roles/ui/add.php

Line 41 in 6ccfcd8

echo PodsForm::field( 'role_label', pods_v( 'role_label', 'post' ), 'text', [

[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

pods/components/Roles/ui/add.php

Line 41 in 6ccfcd8

echo PodsForm::field( 'role_label', pods_v( 'role_label', 'post' ), 'text', [

[phpcs] _{reported by reviewdog 🐶}
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'PodsForm'.

pods/components/Roles/ui/add.php

Line 50 in 6ccfcd8

echo PodsForm::field( 'role_name', pods_v( 'role_name', 'post' ), 'slug', [

[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket
Opening parenthesis of a multi-line function call must be the last content on the line

pods/components/Roles/ui/add.php

Line 50 in 6ccfcd8

echo PodsForm::field( 'role_name', pods_v( 'role_name', 'post' ), 'slug', [

[phpcs] _{reported by reviewdog 🐶}
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'pods_v'.

pods/components/Roles/ui/add.php

Line 50 in 6ccfcd8

echo PodsForm::field( 'role_name', pods_v( 'role_name', 'post' ), 'slug', [

[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

pods/components/Roles/ui/add.php

Line 50 in 6ccfcd8

echo PodsForm::field( 'role_name', pods_v( 'role_name', 'post' ), 'slug', [

[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

pods/components/Roles/ui/add.php

Line 50 in 6ccfcd8

echo PodsForm::field( 'role_name', pods_v( 'role_name', 'post' ), 'slug', [

[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

pods/components/Roles/ui/add.php

Line 50 in 6ccfcd8

echo PodsForm::field( 'role_name', pods_v( 'role_name', 'post' ), 'slug', [

[phpcs] _{reported by reviewdog 🐶}
Squiz.PHP.EmbeddedPhp.ContentAfterOpen
Opening PHP tag must be on a line by itself

pods/components/Roles/ui/add.php

Line 91 in 6ccfcd8

    
           <?php echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [

[phpcs] _{reported by reviewdog 🐶}
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'PodsForm'.

pods/components/Roles/ui/add.php

Line 91 in 6ccfcd8

    
           <?php echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [

[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket
Opening parenthesis of a multi-line function call must be the last content on the line

pods/components/Roles/ui/add.php

Line 91 in 6ccfcd8

    
           <?php echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [

[phpcs] _{reported by reviewdog 🐶}
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$capability'.

pods/components/Roles/ui/add.php

Line 91 in 6ccfcd8

    
           <?php echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [

[phpcs] _{reported by reviewdog 🐶}
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'pods_v'.

pods/components/Roles/ui/add.php

Line 91 in 6ccfcd8

    
           <?php echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [

[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

pods/components/Roles/ui/add.php

Line 91 in 6ccfcd8

    
           <?php echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [

[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

pods/components/Roles/ui/add.php

Line 91 in 6ccfcd8

    
           <?php echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [

[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

pods/components/Roles/ui/add.php

Line 91 in 6ccfcd8

    
           <?php echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [

[phpcs] _{reported by reviewdog 🐶}
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '$obj'

pods/components/Roles/ui/edit.php

Line 24 in 6ccfcd8

echo $obj->message( wp_kses_post( $message ) );

[phpcs] _{reported by reviewdog 🐶}
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$obj'.

pods/components/Roles/ui/edit.php

Line 24 in 6ccfcd8

echo $obj->message( wp_kses_post( $message ) );

[phpcs] _{reported by reviewdog 🐶}
WordPressVIPMinimum.Security.ProperEscapingFunction.htmlAttrNotByEscHTML
Wrong escaping function. HTML attributes should be escaped by esc_attr(), not by esc_html_e().

pods/components/Roles/ui/edit.php

Line 46 in 6ccfcd8

    
           <input type="submit" name="publish" id="publish" class="button-primary" value="<?php esc_html_e( 'Save', 'pods' ); ?>" accesskey="p" />

[phpcs] _{reported by reviewdog 🐶}
Squiz.Strings.EchoedStrings.HasBracket
Echoed strings should not be bracketed

pods/ui/admin/setup-add.php

Line 147 in 6ccfcd8

    
           <div class="pods-wizard-option<?php echo ( ! empty( $quick_actions ) ? ' pods-wizard-option-with-secondary' : '' ); ?>">

[phpcs] _{reported by reviewdog 🐶}
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '!'

pods/ui/admin/setup-add.php

Line 147 in 6ccfcd8

    
           <div class="pods-wizard-option<?php echo ( ! empty( $quick_actions ) ? ' pods-wizard-option-with-secondary' : '' ); ?>">

[phpcs] _{reported by reviewdog 🐶}
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed

pods/ui/admin/setup-add.php

Line 147 in 6ccfcd8

    
           <div class="pods-wizard-option<?php echo ( ! empty( $quick_actions ) ? ' pods-wizard-option-with-secondary' : '' ); ?>">

[phpcs] _{reported by reviewdog 🐶}
Squiz.Strings.EchoedStrings.HasBracket
Echoed strings should not be bracketed

pods/ui/admin/setup-add.php

Line 158 in 6ccfcd8

<?php echo ( $submit_from_linked ? 'class="hidden"' : '' ); ?>>

[phpcs] _{reported by reviewdog 🐶}
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '$submit_from_linked'

pods/ui/admin/setup-add.php

Line 158 in 6ccfcd8

<?php echo ( $submit_from_linked ? 'class="hidden"' : '' ); ?>>

[phpcs] _{reported by reviewdog 🐶}
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed

pods/ui/admin/setup-add.php

Line 158 in 6ccfcd8

<?php echo ( $submit_from_linked ? 'class="hidden"' : '' ); ?>>

PodsBot · 2024-09-12T20:35:47Z

components/Migrate-CPTUI/ui/wizard.php

 											<ul>
 												<?php
 												foreach ( $post_types as $post_type ) {
-													$post_type_name  = pods_var_raw( 'name', $post_type );
-													$post_type_label = pods_var_raw( 'label', $post_type, ucwords( str_replace( '_', ' ', $post_type_name ) ) );
+													$post_type_name  = pods_v( 'name', $post_type );


[phpcs] _{reported by reviewdog 🐶}
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$post_type_name".

PodsBot · 2024-09-12T20:35:47Z

components/Migrate-CPTUI/ui/wizard.php

-													$post_type_name  = pods_var_raw( 'name', $post_type );
-													$post_type_label = pods_var_raw( 'label', $post_type, ucwords( str_replace( '_', ' ', $post_type_name ) ) );
+													$post_type_name  = pods_v( 'name', $post_type );
+													$post_type_label = pods_v( 'label', $post_type, ucwords( str_replace( '_', ' ', $post_type_name ) ) );


[phpcs] _{reported by reviewdog 🐶}
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$post_type_label".

PodsBot · 2024-09-12T20:35:47Z

components/Migrate-CPTUI/ui/wizard.php

 													?>
 													<li>
 														<div class="pods-field pods-boolean">
 															<?php
-															echo PodsForm::field( 'post_type[' . $post_type_name . ']', pods_var_raw( 'post_type[' . $post_type_name . ']', 'post', true ), 'boolean', [
+															echo PodsForm::field( 'post_type[' . $post_type_name . ']', pods_v( 'post_type[' . $post_type_name . ']', 'post', true ), 'boolean', [


[phpcs] _{reported by reviewdog 🐶}
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'PodsForm'.

PodsBot · 2024-09-12T20:35:48Z

components/Migrate-CPTUI/ui/wizard.php

 													?>
 													<li>
 														<div class="pods-field pods-boolean">
 															<?php
-															echo PodsForm::field( 'post_type[' . $post_type_name . ']', pods_var_raw( 'post_type[' . $post_type_name . ']', 'post', true ), 'boolean', [
+															echo PodsForm::field( 'post_type[' . $post_type_name . ']', pods_v( 'post_type[' . $post_type_name . ']', 'post', true ), 'boolean', [


[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket
Opening parenthesis of a multi-line function call must be the last content on the line

PodsBot · 2024-09-12T20:35:48Z

components/Migrate-CPTUI/ui/wizard.php

 													?>
 													<li>
 														<div class="pods-field pods-boolean">
 															<?php
-															echo PodsForm::field( 'post_type[' . $post_type_name . ']', pods_var_raw( 'post_type[' . $post_type_name . ']', 'post', true ), 'boolean', [
+															echo PodsForm::field( 'post_type[' . $post_type_name . ']', pods_v( 'post_type[' . $post_type_name . ']', 'post', true ), 'boolean', [


[phpcs] _{reported by reviewdog 🐶}
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$post_type_name'.

PodsBot · 2024-09-12T20:35:48Z

components/Migrate-CPTUI/ui/wizard.php

 													?>
 													<li>
 														<?php
-														echo PodsForm::field( 'taxonomy[' . $taxonomy_name . ']', pods_var_raw( 'taxonomy[' . $taxonomy_name . ']', 'post', true ), 'boolean', [
+														echo PodsForm::field( 'taxonomy[' . $taxonomy_name . ']', pods_v( 'taxonomy[' . $taxonomy_name . ']', 'post', true ), 'boolean', [


[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

PodsBot · 2024-09-12T20:35:49Z

components/Roles/Roles.php

@@ -321,9 +325,9 @@

 		$capabilities = $this->get_capabilities();

-		$params->capabilities = (array) pods_var_raw( 'capabilities', $params, array() );
+		$params->capabilities = (array) pods_v( 'capabilities', $params, array() );


[phpcs] _{reported by reviewdog 🐶}
Generic.Arrays.DisallowLongArraySyntax.Found
Short array syntax must be used to define arrays

PodsBot · 2024-09-12T20:35:49Z

components/Roles/Roles.php


-		$params->custom_capabilities = (array) pods_var_raw( 'custom_capabilities', $params, array() );
+		$params->custom_capabilities = (array) pods_v( 'custom_capabilities', $params, array() );


[phpcs] _{reported by reviewdog 🐶}
Generic.Arrays.DisallowLongArraySyntax.Found
Short array syntax must be used to define arrays

PodsBot · 2024-09-12T20:35:49Z

components/Roles/ui/add.php

-									echo PodsForm::field( 'role_label', pods_var_raw( 'role_label', 'post' ), 'text', [
-										'class'       => 'pods-validate pods-validate-required',
-										'disable_dfv' => true,
+									echo PodsForm::field( 'role_label', pods_v( 'role_label', 'post' ), 'text', [


[phpcs] _{reported by reviewdog 🐶}
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'PodsForm'.

PodsBot · 2024-09-12T20:35:49Z

components/Roles/ui/add.php

-									echo PodsForm::field( 'role_label', pods_var_raw( 'role_label', 'post' ), 'text', [
-										'class'       => 'pods-validate pods-validate-required',
-										'disable_dfv' => true,
+									echo PodsForm::field( 'role_label', pods_v( 'role_label', 'post' ), 'text', [


[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket
Opening parenthesis of a multi-line function call must be the last content on the line

PodsBot · 2024-09-12T20:37:52Z

components/Roles/ui/add.php

-									echo PodsForm::field( 'role_label', pods_var_raw( 'role_label', 'post' ), 'text', [
-										'class'       => 'pods-validate pods-validate-required',
-										'disable_dfv' => true,
+									echo PodsForm::field( 'role_label', pods_v( 'role_label', 'post' ), 'text', [


[phpcs] _{reported by reviewdog 🐶}
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'pods_v'.

PodsBot · 2024-09-12T20:37:52Z

components/Roles/ui/add.php

-									echo PodsForm::field( 'role_label', pods_var_raw( 'role_label', 'post' ), 'text', [
-										'class'       => 'pods-validate pods-validate-required',
-										'disable_dfv' => true,
+									echo PodsForm::field( 'role_label', pods_v( 'role_label', 'post' ), 'text', [


[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

PodsBot · 2024-09-12T20:37:52Z

components/Roles/ui/add.php

-									echo PodsForm::field( 'role_label', pods_var_raw( 'role_label', 'post' ), 'text', [
-										'class'       => 'pods-validate pods-validate-required',
-										'disable_dfv' => true,
+									echo PodsForm::field( 'role_label', pods_v( 'role_label', 'post' ), 'text', [


[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

PodsBot · 2024-09-12T20:37:52Z

components/Roles/ui/add.php

-									echo PodsForm::field( 'role_label', pods_var_raw( 'role_label', 'post' ), 'text', [
-										'class'       => 'pods-validate pods-validate-required',
-										'disable_dfv' => true,
+									echo PodsForm::field( 'role_label', pods_v( 'role_label', 'post' ), 'text', [


[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

PodsBot · 2024-09-12T20:37:52Z

components/Roles/ui/add.php

-										'attributes'  => [ 'data-sluggable' => 'role_label' ],
-										'class'       => 'pods-validate pods-validate-required pods-slugged-lower',
-										'disable_dfv' => true,
+									echo PodsForm::field( 'role_name', pods_v( 'role_name', 'post' ), 'slug', [


[phpcs] _{reported by reviewdog 🐶}
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'PodsForm'.

PodsBot · 2024-09-12T20:37:53Z

components/Roles/ui/add.php

@@ -90,7 +88,7 @@
 												$zebra = ( ! $zebra );
 												?>
 												<li class="pods-zebra-<?php echo esc_attr( $class ); ?>" data-capability="<?php echo esc_attr( $capability ); ?>">
-													<?php echo PodsForm::field( 'capabilities[' . $capability . ']', pods_var_raw( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [
+													<?php echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [


[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

PodsBot · 2024-09-12T20:37:53Z

components/Roles/ui/add.php

@@ -90,7 +88,7 @@
 												$zebra = ( ! $zebra );
 												?>
 												<li class="pods-zebra-<?php echo esc_attr( $class ); ?>" data-capability="<?php echo esc_attr( $capability ); ?>">
-													<?php echo PodsForm::field( 'capabilities[' . $capability . ']', pods_var_raw( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [
+													<?php echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [


[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

PodsBot · 2024-09-12T20:37:53Z

components/Roles/ui/edit.php

@@ -21,11 +21,11 @@

 				$message = sprintf( __( '<strong>Success!</strong> %1$s %2$s successfully.', 'pods' ), $obj->item, $action );

-				echo $obj->message( $message );
+				echo $obj->message( wp_kses_post( $message ) );


[phpcs] _{reported by reviewdog 🐶}
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '$obj'

PodsBot · 2024-09-12T20:37:53Z

components/Roles/ui/edit.php

@@ -21,11 +21,11 @@

 				$message = sprintf( __( '<strong>Success!</strong> %1$s %2$s successfully.', 'pods' ), $obj->item, $action );

-				echo $obj->message( $message );
+				echo $obj->message( wp_kses_post( $message ) );


[phpcs] _{reported by reviewdog 🐶}
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$obj'.

PodsBot · 2024-09-12T20:37:53Z

components/Roles/ui/edit.php


 								<div class="inside">
 									<div class="submitbox" id="submitpost">
 										<div id="minor-publishing">
 											<div id="major-publishing-actions">
 												<div id="publishing-action">
 													<img class="waiting" src="<?php echo esc_url( admin_url( 'images/wpspin_light.gif' ) ); ?>" alt="" />
-													<input type="submit" name="publish" id="publish" class="button-primary" value="<?php _e( 'Save', 'pods' ); ?>" accesskey="p" />
+													<input type="submit" name="publish" id="publish" class="button-primary" value="<?php esc_html_e( 'Save', 'pods' ); ?>" accesskey="p" />


[phpcs] _{reported by reviewdog 🐶}
WordPressVIPMinimum.Security.ProperEscapingFunction.htmlAttrNotByEscHTML
Wrong escaping function. HTML attributes should be escaped by esc_attr(), not by esc_html_e().

ui/js/jquery.pods.js

PodsBot · 2024-09-13T20:26:43Z

components/Roles/ui/edit.php

@@ -99,7 +99,7 @@
 														?>
 														<li class="pods-zebra-<?php echo esc_attr( $class ); ?>" data-capability="<?php echo esc_attr( $capability ); ?>">
 															<?php
-															echo PodsForm::field( 'capabilities[' . $capability . ']', pods_var_raw( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [
+															echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [


[phpcs] _{reported by reviewdog 🐶}
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'PodsForm'.

PodsBot · 2024-09-13T20:26:43Z

components/Roles/ui/edit.php

@@ -99,7 +99,7 @@
 														?>
 														<li class="pods-zebra-<?php echo esc_attr( $class ); ?>" data-capability="<?php echo esc_attr( $capability ); ?>">
 															<?php
-															echo PodsForm::field( 'capabilities[' . $capability . ']', pods_var_raw( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [
+															echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [


[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket
Opening parenthesis of a multi-line function call must be the last content on the line

PodsBot · 2024-09-13T20:26:43Z

components/Roles/ui/edit.php

@@ -99,7 +99,7 @@
 														?>
 														<li class="pods-zebra-<?php echo esc_attr( $class ); ?>" data-capability="<?php echo esc_attr( $capability ); ?>">
 															<?php
-															echo PodsForm::field( 'capabilities[' . $capability . ']', pods_var_raw( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [
+															echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [


[phpcs] _{reported by reviewdog 🐶}
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$capability'.

PodsBot · 2024-09-13T20:26:43Z

components/Roles/ui/edit.php

@@ -99,7 +99,7 @@
 														?>
 														<li class="pods-zebra-<?php echo esc_attr( $class ); ?>" data-capability="<?php echo esc_attr( $capability ); ?>">
 															<?php
-															echo PodsForm::field( 'capabilities[' . $capability . ']', pods_var_raw( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [
+															echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [


[phpcs] _{reported by reviewdog 🐶}
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'pods_v'.

PodsBot · 2024-09-13T20:26:44Z

components/Roles/ui/edit.php

@@ -99,7 +99,7 @@
 														?>
 														<li class="pods-zebra-<?php echo esc_attr( $class ); ?>" data-capability="<?php echo esc_attr( $capability ); ?>">
 															<?php
-															echo PodsForm::field( 'capabilities[' . $capability . ']', pods_var_raw( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [
+															echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [


[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

PodsBot · 2024-09-13T20:26:44Z

components/Roles/ui/edit.php

@@ -99,7 +99,7 @@
 														?>
 														<li class="pods-zebra-<?php echo esc_attr( $class ); ?>" data-capability="<?php echo esc_attr( $capability ); ?>">
 															<?php
-															echo PodsForm::field( 'capabilities[' . $capability . ']', pods_var_raw( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [
+															echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [


[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

PodsBot · 2024-09-13T20:26:44Z

components/Roles/ui/edit.php

@@ -99,7 +99,7 @@
 														?>
 														<li class="pods-zebra-<?php echo esc_attr( $class ); ?>" data-capability="<?php echo esc_attr( $capability ); ?>">
 															<?php
-															echo PodsForm::field( 'capabilities[' . $capability . ']', pods_var_raw( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [
+															echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [


[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

PodsBot · 2024-09-14T01:55:57Z

ui/admin/setup-add.php

 									</a>
 								</div>

-								<div class="pods-wizard-option">
+								<div class="pods-wizard-option<?php echo ! empty( $quick_actions ) ? ' pods-wizard-option-with-secondary' : ''; ?>">


[phpcs] _{reported by reviewdog 🐶}
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed

PodsBot · 2024-09-14T01:55:57Z

ui/admin/setup-add.php

+
+									<?php if ( ! empty( $quick_actions ) ) : ?>
+										<div id="pods-wizard-quick-actions"
+											<?php echo $submit_from_linked ? 'class="hidden"' : ''; ?>>


[phpcs] _{reported by reviewdog 🐶}
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed

PodsBot · 2024-09-14T01:55:57Z

ui/admin/setup-add.php

@@ -569,6 +567,14 @@
 								</div>
 							</div>
 						</div>
+
+						<div id="pods-wizard-quick-actions-saving-in-progress"
+							<?php echo ! $submit_from_linked ? 'class="hidden"' : ''; ?>>


[phpcs] _{reported by reviewdog 🐶}
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed

Set version to 3.2.8-a-1

41333b9

PodsBot added the Type: Release label Aug 31, 2024

PodsBot assigned sc0ttkclark Aug 31, 2024

sc0ttkclark added 3 commits August 30, 2024 20:31

Support enabling or disabling wpautop for certain kinds of block content

e93f06c

Add fallback for $pod->field() and the find argument in case the …

cae1001

…Pods object is not returned

Disable phpcs rule for brackets and phpstan fix

8b99c43

PodsBot commented Aug 31, 2024

View reviewed changes

sc0ttkclark added 3 commits August 30, 2024 20:39

Disable phpcs rule

76075de

Update TribalScents to StellarWP

194a0f6

Update phpcs rules

6dee8cc

PodsBot commented Aug 31, 2024

View reviewed changes

Update rules

b4f95c0

sc0ttkclark marked this pull request as ready for review August 31, 2024 02:24

sc0ttkclark requested review from sc0ttkclark and JoryHogeveen as code owners August 31, 2024 02:24

sc0ttkclark marked this pull request as draft August 31, 2024 02:24

Update phpcs

e449c2f

pods-framework deleted a comment from PodsBot Aug 31, 2024

sc0ttkclark added 2 commits August 31, 2024 08:55

Exclude rules

8875680

Update rules

06183dd

PodsBot commented Aug 31, 2024

View reviewed changes

sc0ttkclark added 8 commits August 31, 2024 09:48

Fix phpcs

c767aa3

Update reference

49cabbf

Update jest

523481f

Try updating enzyme testing adapter

164b45d

Install the enzyme adapter

9ef034a

Update enzyme adapter

0f36814

Update adapter version

d385823

Update connection description

84629bd

heybran and others added 13 commits September 7, 2024 17:04

update add new pods screen (#7161)

1467a9d

build css output (#7161)

df5f5b3

remove commented out codes (#7161)

3ea326d

Rebuild assets

2b4f0cd

More UX updates

99a2a69

Tweak heading text

28ada55

Remove extra padding

163b438

More CSS work for Add New Pod screen

da75987

Disable more post types

61e9903

Update wizard handling for quick actions

6c3f61f

Add taxonomy exclusion

acb09ab

Feature/7161 add new pod screen UI enhancement (#7230)

2cc4c83

Auto rebuild assets

cbd2c24

PodsBot commented Sep 10, 2024

View reviewed changes

sc0ttkclark added 2 commits September 10, 2024 09:49

Update padding for wizard

65ff349

Revamp wizard screens across all components

6ccfcd8

PodsBot commented Sep 12, 2024

View reviewed changes

Auto rebuild assets

9b36ded

PodsBot commented Sep 12, 2024

View reviewed changes

github-advanced-security bot found potential problems Sep 12, 2024

View reviewed changes

ui/js/jquery.pods.js Fixed Show fixed Hide fixed

ui/js/jquery.pods.js Fixed Show fixed Hide fixed

ui/js/jquery.pods.js Fixed Show fixed Hide fixed

sc0ttkclark added 2 commits September 12, 2024 15:40

Update artifact

be8e86d

More fixes for slug sanitization

b4b5752

github-advanced-security bot found potential problems Sep 13, 2024

View reviewed changes

ui/js/jquery.pods.js Fixed Show fixed Hide fixed

ui/js/jquery.pods.js Fixed Show fixed Hide fixed

ui/js/jquery.pods.js Dismissed Show dismissed Hide dismissed

ui/js/jquery.pods.js Dismissed Show dismissed Hide dismissed

Fixes for phpstan

9e46547

PodsBot commented Sep 13, 2024

View reviewed changes

sc0ttkclark added 3 commits September 13, 2024 20:28

Simplify slug logic

95e15fb

Fix HTML formatting

18c0caa

More phpcs fixes

83016f5

PodsBot commented Sep 14, 2024

View reviewed changes

sc0ttkclark marked this pull request as ready for review September 14, 2024 15:11


		$params->custom_capabilities = (array) pods_var_raw( 'custom_capabilities', $params, array() );
		$params->custom_capabilities = (array) pods_v( 'custom_capabilities', $params, array() );

Pods 3.2.8 #7347

Are you sure you want to change the base?

Pods 3.2.8 #7347

Conversation

PodsBot commented Aug 31, 2024

what-the-diff bot commented Aug 31, 2024 • edited Loading

PR Summary

PodsBot left a comment

Choose a reason for hiding this comment

PodsBot left a comment

Choose a reason for hiding this comment

PodsBot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PodsBot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

what-the-diff bot commented Aug 31, 2024 •

edited

Loading