Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polkadot Protocol > Protocol Components > Accounts > Account Balance Types #63

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Polkadot Protocol > Protocol Components > Accounts > Account Balance Types #63

wants to merge 14 commits into from

Conversation

kapetan3sid
Copy link
Collaborator

@kapetan3sid kapetan3sid self-assigned this Sep 26, 2024
CrackTheCode016
CrackTheCode016 previously approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@CrackTheCode016 CrackTheCode016 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just some minor stuff to remove before merging

.DS_Store Outdated Show resolved Hide resolved
images/.DS_Store Outdated Show resolved Hide resolved
images/polkadot-protocol/.DS_Store Outdated Show resolved Hide resolved
images/polkadot-protocol/protocol-components/.DS_Store Outdated Show resolved Hide resolved
images/polkadot-protocol/protocol-components/accounts/.DS_Store Outdated Show resolved Hide resolved
polkadot-protocol/protocol-components/accounts/account-balance-types.md Outdated Show resolved Hide resolved
0xLucca
0xLucca reviewed Sep 27, 2024
View reviewed changes
polkadot-protocol/protocol-components/accounts/account-balance-types.md Outdated Show resolved Hide resolved
polkadot-protocol/protocol-components/accounts/account-balance-types.md Show resolved Hide resolved
polkadot-protocol/protocol-components/accounts/account-balance-types.md Outdated Show resolved Hide resolved
polkadot-protocol/protocol-components/accounts/account-balance-types.md Outdated Show resolved Hide resolved
polkadot-protocol/protocol-components/accounts/account-balance-types.md Outdated Show resolved Hide resolved
polkadot-protocol/protocol-components/accounts/account-balance-types.md Outdated Show resolved Hide resolved
polkadot-protocol/protocol-components/accounts/account-balance-types.md Outdated Show resolved Hide resolved
polkadot-protocol/protocol-components/accounts/account-balance-types.md Outdated Show resolved Hide resolved
polkadot-protocol/protocol-components/accounts/account-balance-types.md Outdated Show resolved Hide resolved
polkadot-protocol/protocol-components/accounts/account-balance-types.md Outdated Show resolved Hide resolved
kapetan3sid and others added 9 commits September 27, 2024 14:36
@kapetan3sid @0xLucca
format text
7512278 
Co-authored-by: 0xLucca <95830307+0xLucca@users.noreply.github.com>
@kapetan3sid @0xLucca
format-text-2
2354ef3 
Co-authored-by: 0xLucca <95830307+0xLucca@users.noreply.github.com>
@kapetan3sid @0xLucca
format-text-3
fd081ff 
Co-authored-by: 0xLucca <95830307+0xLucca@users.noreply.github.com>
@kapetan3sid @0xLucca
format-text-4
4b6625d 
Co-authored-by: 0xLucca <95830307+0xLucca@users.noreply.github.com>
@kapetan3sid @0xLucca
format-text-5
05de73d 
Co-authored-by: 0xLucca <95830307+0xLucca@users.noreply.github.com>
@kapetan3sid @0xLucca
format-text-6
f9315dd 
Co-authored-by: 0xLucca <95830307+0xLucca@users.noreply.github.com>
@kapetan3sid @CrackTheCode016
format-text-7
3148965 
Co-authored-by: bader y <ibnbassem@gmail.com>
@kapetan3sid @0xLucca
format-text-8
5705afa 
Co-authored-by: 0xLucca <95830307+0xLucca@users.noreply.github.com>
@kapetan3sid
applied all the recommendations from luca and bader
76adf09
0xLucca
0xLucca previously approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@0xLucca 0xLucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xLucca 0xLucca requested a review from eshaben October 1, 2024 19:03
CrackTheCode016
CrackTheCode016 previously approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@CrackTheCode016 CrackTheCode016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice work

@eshaben eshaben requested a review from a team as a code owner October 4, 2024 01:46
@eshaben eshaben requested review from dawnkelly09 and removed request for eshaben October 4, 2024 01:47
@eshaben
Copy link
Collaborator

eshaben commented Oct 4, 2024

@dawnkelly09 - please check this over to make sure I didn't miss anything 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CrackTheCode016 CrackTheCode016 CrackTheCode016 approved these changes

@0xLucca 0xLucca 0xLucca left review comments

@nhussein11 nhussein11 Awaiting requested review from nhussein11

@DrW3RK DrW3RK Awaiting requested review from DrW3RK

@dawnkelly09 dawnkelly09 Awaiting requested review from dawnkelly09

At least 2 approving reviews are required to merge this pull request.

Assignees

@kapetan3sid kapetan3sid

Labels
Polkadot Protocol Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kapetan3sid @eshaben @CrackTheCode016 @0xLucca