Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Substrate.io Migration] - Polkadot Protocol > Protocol Components > Transactions > Transactions Formats #80

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

nhussein11
Copy link
Collaborator

This PR aims to migrate this page of the substrate tutorials: https://docs.substrate.io/learn/transaction-formats/

Disclaimer: I did not migrate this section: https://docs.substrate.io/reference/transaction-format/#:~:text=Polkadot%20JS%20Apps%20example%3A

Since I believe that would fit better in the tutorials section, maybe we can add a reference to that part in the future. However, I'm open to discuss about it :)

Copy link
Collaborator

@CrackTheCode016 CrackTheCode016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good, just a few suggestions for the content

@nhussein11 nhussein11 requested review from CrackTheCode016 and a team October 4, 2024 02:09
CrackTheCode016
CrackTheCode016 previously approved these changes Oct 4, 2024
Copy link
Collaborator

@CrackTheCode016 CrackTheCode016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm, the back linking to the psdk is especially important here


Then, some additional data that's not part of what gets signed is required, which includes:

- The spec version and the transaction version ensure that the transaction is submitted to a [compatible runtime](TODO:update-path){target=\_blank}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would you link in compatible runtime?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the bader's suggestions were linking this part with "Upgrade your runtime"

nhussein11 and others added 2 commits October 4, 2024 10:23
Co-authored-by: 0xLucca <95830307+0xLucca@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants