Fix return type of emscripten_glfw_is_window_fullscreen #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm trying to change the type of EM_BOOL and this is currently blocking that: emscripten-core/emscripten#22155
ypujante
reviewed
Jun 27, 2024
|
The problem is that your fix is not changing include/GLFW/emscripten_glfw3.h where it is defined... |
|
@sbc100 I think I understand what you are doing (which you could have explained...) You changed (but KEPT) the define from But my code in I will patch it... |
|
Yeah its not important (to me) what the return type of this function is.. as long as the header and source agree. |
|
Would you mind sending a PR to emscripten to update the port? (or should I just do it as part of my PR?) |
|
@sbc100 I am already in the process... should take a few minutes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to change the type of EM_BOOL and this is currently blocking that:
emscripten-core/emscripten#22155