Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print url when download fails #1285

Merged

Conversation

grahamgower
Copy link
Member

Closes #697.

@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #1285 (117e9d7) into main (f782e49) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1285   +/-   ##
=======================================
  Coverage   99.66%   99.66%           
=======================================
  Files         111      111           
  Lines        3559     3563    +4     
  Branches      438      438           
=======================================
+ Hits         3547     3551    +4     
  Misses          8        8           
  Partials        4        4           
Impacted Files Coverage Δ
stdpopsim/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f782e49...117e9d7. Read the comment docs.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grahamgower grahamgower merged commit f76b1c7 into popsim-consortium:main Jun 1, 2022
@grahamgower grahamgower deleted the download-error-message branch November 9, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

utils.download() should report the url when a download fails
2 participants