Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update linters #674

Merged
merged 8 commits into from
Mar 6, 2024
Merged

Update linters #674

merged 8 commits into from
Mar 6, 2024

Conversation

illusional
Copy link
Contributor

  • Add ruff, mypy, shellcheck
  • Update linters where required
  • Update GH action versions
  • Removed pylint decorators
  • Add CPG ID checker

@illusional illusional requested a review from nevoodoo March 6, 2024 01:12
nevoodoo
nevoodoo approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@nevoodoo nevoodoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a quick scan, mostly linting and better typing annotations from what I can see. As long as the airtable files are def supposed to be deleted, this looks good to my eye!

@illusional illusional merged commit 7781743 into main Mar 6, 2024
4 checks passed
@illusional illusional deleted the update-linters branch March 6, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nevoodoo nevoodoo nevoodoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illusional @nevoodoo